Re: [PATCH v2] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL
Date	Tue, 08 Aug 2017 14:10:03 +0200
Message-ID	<ucbuH-8cT-45@gated-at.bofh.it> (permalink)
References	<tJQJk-31p-13@gated-at.bofh.it> <ubMmB-6k5-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1502193990; bh=q202tl53Jpgm/Ui1klXI+YX3cyxL+GaCEDCDKTYdy38=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=FR6PAOsNvS8uoKlt7WRwTTIz3e5o4+WzocIeQjLo8jEKBCq7h/FmwENiTHt2Kqy9u ZB0I3DD5yfOhEVN1ZOBwzQyB8I8a0EPuss12Tp9HvGN7t+11Kah6S1AQxcxtx7GdsG A0max9gbJ/h7SxpcVxypmsub2YlrXqgI+fIzBTDI=
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	<nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, linux-omap <linux-omap@vger.kernel.org>
X-Original-Date	Tue, 8 Aug 2017 17:36:26 +0530
X-Original-Message-ID	<0a90f02c-49e4-c4f1-5264-1b963902ff68@ti.com>
X-Original-References	<1495440630-21332-1-git-send-email-rogerq@ti.com> <c7bc0f49-f120-d195-5d40-3d0f9f8962d2@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1706453

Show key headers only | View raw


On Monday 07 August 2017 02:41 PM, Roger Quadros wrote:
> The AM572x Technical Reference Manual, SPRUHZ6H,
> Revised November 2016 [1], shows recommended settings for the
> SATA DPLL in Table 26-8. DPLL CLKDCOLDO Recommended Settings.
> 
> Use those settings in the driver. The TRM does not show
> a value for 20MHz SYS_CLK so we use something close to the
> 26MHz setting.
> 
> [1] - http://www.ti.com/lit/ug/spruhz6h/spruhz6h.pdf
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> [nsekhar@ti.com: add exact TRM version to commit text]
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

merged, thanks!

-Kishon
> ---
> v2:
> - Mention full TRM version in commit log
> 
>  drivers/phy/ti/phy-ti-pipe3.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c
> index 9c84d32..0e564f3 100644
> --- a/drivers/phy/ti/phy-ti-pipe3.c
> +++ b/drivers/phy/ti/phy-ti-pipe3.c
> @@ -118,12 +118,12 @@ static struct pipe3_dpll_map dpll_map_usb[] = {
>  };
>  
>  static struct pipe3_dpll_map dpll_map_sata[] = {
> -	{12000000, {1000, 7, 4, 6, 0} },	/* 12 MHz */
> -	{16800000, {714, 7, 4, 6, 0} },		/* 16.8 MHz */
> +	{12000000, {625, 4, 4, 6, 0} },	/* 12 MHz */
> +	{16800000, {625, 6, 4, 7, 0} },		/* 16.8 MHz */
>  	{19200000, {625, 7, 4, 6, 0} },		/* 19.2 MHz */
> -	{20000000, {600, 7, 4, 6, 0} },		/* 20 MHz */
> -	{26000000, {461, 7, 4, 6, 0} },		/* 26 MHz */
> -	{38400000, {312, 7, 4, 6, 0} },		/* 38.4 MHz */
> +	{20000000, {750, 9, 4, 6, 0} },		/* 20 MHz */
> +	{26000000, {750, 12, 4, 6, 0} },	/* 26 MHz */
> +	{38400000, {625, 15, 4, 6, 0} },	/* 38.4 MHz */
>  	{ },					/* Terminator */
>  };
>  
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL Roger Quadros <rogerq@ti.com> - 2017-08-07 11:20 +0200
  Re: [PATCH v2] phy: ti-pipe3: Use TRM recommended settings for SATA  DPLL Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-08 14:10 +0200

csiph-web