Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706472

Re: [PATCH] staging: pi433: style fix - space after asterisk

Show all headers | View raw

Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>

Thank you Marcin!

> Marcin Ciupak <marcin.s.ciupak@gmail.com> hat am 8. August 2017 um 15:54
> geschrieben:
>
>
> This patch is intended to fix coding style issues in order to comply
> with kernel coding style guide as requested by TODO file.
>
> It fixes the following checkpatch.pl error:
>
> ERROR: "foo * bar" should be "foo *bar"
>
> Note:
> "WARNING: line over 80 characters" remains valid here and could be fixed
> by another patch.
>
> Signed-off-by: Marcin Ciupak <marcin.s.ciupak@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 2 +-
> drivers/staging/pi433/rf69.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index f83523e3395d..9f4e7173c688 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -740,7 +740,7 @@ int rf69_set_sync_values(struct spi_device *spi, u8
> syncValues[8])
> return retval;
> }
>
> -int rf69_set_packet_format(struct spi_device * spi, enum packetFormat
> packetFormat)
> +int rf69_set_packet_format(struct spi_device *spi, enum packetFormat
> packetFormat)
> {
> #ifdef DEBUG
> dev_dbg(&spi->dev, "set: packet format");
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
> index b81e0762032e..fbccaae51c61 100644
> --- a/drivers/staging/pi433/rf69.h
> +++ b/drivers/staging/pi433/rf69.h
> @@ -61,7 +61,7 @@ int rf69_set_fifo_fill_condition(struct spi_device *spi,
> enum fifoFillCondition
> int rf69_set_sync_size(struct spi_device *spi, u8 sync_size);
> int rf69_set_sync_tolerance(struct spi_device *spi, u8 syncTolerance);
> int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8]);
> -int rf69_set_packet_format(struct spi_device * spi, enum packetFormat
> packetFormat);
> +int rf69_set_packet_format(struct spi_device *spi, enum packetFormat
> packetFormat);
> int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff);
> int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering
> addressFiltering);
> int rf69_set_payload_length(struct spi_device *spi, u8 payloadLength);
> --
> 2.13.0
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: pi433: style fix - space after asterisk Marcin Ciupak <marcin.s.ciupak@gmail.com> - 2017-08-08 14:00 +0200
  Re: [PATCH] staging: pi433: style fix - space after asterisk Marcus Wolf <linux@wolf-entwicklungen.de> - 2017-08-08 14:20 +0200

csiph-web