Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706320

Re: [PATCH v8 01/12] mfd: rk808: fix up the chip id get failed

Show all headers | View raw

On Thu, 03 Aug 2017, Joseph Chen wrote:

> From: Elaine Zhang <zhangqing@rock-chips.com>
> 
> the rk8xx chip id is:
> ((MSB << 8) | LSB) & 0xfff0
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
> ---
>  drivers/mfd/rk808.c       | 21 +++++++++++++++------
>  include/linux/mfd/rk808.h |  1 +
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index fd087cb..3334a2a 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -325,7 +325,7 @@ static int rk808_probe(struct i2c_client *client,
>  	void (*pm_pwroff_fn)(void);
>  	int nr_pre_init_regs;
>  	int nr_cells;
> -	int pm_off = 0;
> +	int pm_off = 0, msb, lsb;
>  	int ret;
>  	int i;
>  
> @@ -333,14 +333,23 @@ static int rk808_probe(struct i2c_client *client,
>  	if (!rk808)
>  		return -ENOMEM;
>  
> -	rk808->variant = i2c_smbus_read_word_data(client, RK808_ID_MSB);
> -	if (rk808->variant < 0) {
> -		dev_err(&client->dev, "Failed to read the chip id at 0x%02x\n",
> +	/* read Chip variant */

Nit: This should read "Read chip variant"

However, I realise that the rest of the comments do not use correctly
formatted English grammar either, so just s/Chip/chip/.

Once fixed you can apply my:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 00/12] rk808: Add RK805 support Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
  [PATCH v8 04/12] mfd: rk808: Add RK805 support Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 04/12] mfd: rk808: Add RK805 support Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:50 +0200
  [PATCH v8 06/12] rtc: Kconfig: Name RK805 in Kconfig for RTC_DRV_RK808 Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
  [PATCH v8 09/12] Input: Add power key driver for Rockchip RK805 PMIC Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
  [PATCH v8 05/12] clk: Kconfig: Name RK805 in Kconfig for COMMON_CLK_RK808 Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
  [PATCH v8 02/12] mfd: rk808: add rk805 regs addr and ID Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 02/12] mfd: rk808: add rk805 regs addr and ID Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:40 +0200
  [PATCH v8 08/12] pinctrl: Add pinctrl driver for the RK805 PMIC Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 08/12] pinctrl: Add pinctrl driver for the RK805 PMIC Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 14:50 +0200
  [PATCH v8 07/12] mfd: dt-bindings: Add RK805 device tree bindings document Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 07/12] mfd: dt-bindings: Add RK805 device tree  bindings document Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:50 +0200
  [PATCH v8 11/12] mfd: rk808: Add RK805 power key support Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 11/12] mfd: rk808: Add RK805 power key support Lee Jones <lee.jones@linaro.org> - 2017-08-08 13:00 +0200
  [PATCH v8 10/12] mfd: rk808: Add RK805 pinctrl support Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 10/12] mfd: rk808: Add RK805 pinctrl support Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:50 +0200
  [PATCH v8 01/12] mfd: rk808: fix up the chip id get failed Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200
    Re: [PATCH v8 01/12] mfd: rk808: fix up the chip id get failed Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:50 +0200
  [PATCH v8 12/12] pinctrl: dt-bindings: add bindings for Rockchip RK805 PMIC Joseph Chen <chenjh@rock-chips.com> - 2017-08-03 14:30 +0200

csiph-web