Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1706378

[PATCH 1/3] drm/bridge: make drm_connector_funcs structures const

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Bhumika Goyal <bhumirks@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] drm/bridge: make drm_connector_funcs structures const
Date Tue, 08 Aug 2017 13:30:02 +0200
Message-ID <ucaRY-7FO-29@gated-at.bofh.it> (permalink)
References <ucaRY-7FO-13@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L59SNBKOEqM2N+2isi0TAyI1J9dggnNrV5LNVKB2cjk=; b=ctVwaehCJ9YrqOsE/ZICKJSinOQTz+pcVD0zF8kmqEznBLt8CfQx9ldeyHj0A9R53R vi1C5SJNNg7lv49CEbgoOXTuccTHxnJQHH4zqaOQQWOSu4FvaLe4X9/EnPTcpQ3y51Wv yqwqTMFyGF4eYl8Wr9ioibi70wgu4c6dM2tks+Q7kO3l5MvJKmkN24Sbh/CqBgt/XwOD gtnk571rIVegzHCGhAdBNLMkcKd8SeSs7vrsMeol+owJgjbStDHk7xiU2C1N8Jw5eRSq NmooCjXBqOem1/24WhMLXMyNA0E9hz4Zs4GPoJVtzOHv77ibQMl7gMm8QxgVimI1LR/D 4bkA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L59SNBKOEqM2N+2isi0TAyI1J9dggnNrV5LNVKB2cjk=; b=YC0K2u5Rjtd+N6aaHoWU5VzSWOcUsdSYpkJpXJNG+Wx6WQpPrMR5SKsqTY6m/fmyhg 2359Mh4knmBhMH6hE2dW8QOdqAv9zK6BSv7H9j2Xilp3AWT5CxcZGqt+dtnLPmtvqrEb oNAyo5DAykUMI5ULPBGl1kGeRe1WbPl2jDn6u9rMiEorMktcajn2UDgqjGCpvJvoCEKM OPJyWj6es5Ss7tobNzkNgr+tUBmtWo0VgsXb0I2oARw0z6wkqHLhYqW62mIw4tiHlUHk a53/UU3W4qL2WQ6Qa5o5fu1NN1ut2g0Yy+6btnabglWvKSoS0+rAWDmKPyCsN0sgGW1p Illg==
X-Gm-Message-State AHYfb5iZgujQ38cvkkRUbkzAMWVdy74A5+9+ryighKFVt8JXeVvvJJtf IVegGQTYDEtrU6Lr
X-Received by 10.99.54.1 with SMTP id d1mr3633155pga.326.1502191762528; Tue, 08 Aug 2017 04:29:22 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 55
Organization linux.* mail to news gateway
X-Original-Cc Bhumika Goyal <bhumirks@gmail.com>
X-Original-Date Tue, 8 Aug 2017 16:58:30 +0530
X-Original-Message-ID <1502191712-11231-2-git-send-email-bhumirks@gmail.com>
X-Original-References <1502191712-11231-1-git-send-email-bhumirks@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1706378

Show key headers only | View raw


Make these const as they are only passed to the function
drm_connector_init and the corresponding argument is of type const.
Done using Coccinelle

@match disable optional_qualifier@
identifier s;
@@
static struct drm_connector_funcs s = {...};

@ref@
position p;
identifier match.s;
@@
s@p

@good1@
identifier match.s;
expression e1,e2;
position ref.p;
@@
drm_connector_init(e1,e2,&s@p,...)

@bad depends on  !good1@
position ref.p;
identifier match.s;
@@
s@p

@depends on forall !bad disable optional_qualifier@
identifier match.s;
@@
static
+ const
struct drm_connector_funcs s;

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ff9792d..ee16635 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -785,7 +785,7 @@ static int adv7511_connector_get_modes(struct drm_connector *connector)
 	return adv7511_detect(adv, connector);
 }
 
-static struct drm_connector_funcs adv7511_connector_funcs = {
+static const struct drm_connector_funcs adv7511_connector_funcs = {
 	.dpms = drm_atomic_helper_connector_dpms,
 	.fill_modes = drm_helper_probe_single_connector_modes,
 	.detect = adv7511_connector_detect,
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] drm: make drm_connector_funcs structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-08 13:30 +0200
  [PATCH 1/3] drm/bridge: make drm_connector_funcs structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-08 13:30 +0200
    Re: [PATCH 1/3] drm/bridge: make drm_connector_funcs structures const Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-08 14:10 +0200
  [PATCH 2/3] drm/sun4i: make drm_connector_funcs structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-08 13:30 +0200
  [PATCH 3/3] drm/rockchip: make drm_connector_funcs structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-08 13:30 +0200
  Re: [PATCH 0/3] drm: make drm_connector_funcs structures const Archit Taneja <architt@codeaurora.org> - 2017-08-09 12:40 +0200
    Re: [PATCH 0/3] drm: make drm_connector_funcs structures const Daniel Vetter <daniel@ffwll.ch> - 2017-08-09 18:40 +0200
      Re: [PATCH 0/3] drm: make drm_connector_funcs structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-10 08:30 +0200

csiph-web