Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706306

Re: [PATCH] mmc: renesas-sdhi: constify renesas_sdhi_internal_dmac_dma_ops

Show all headers | View raw

On 7 August 2017 at 22:15, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> The structure renesas_sdhi_internal_dmac_dma_ops is only passed as
> the second argument to renesas_sdhi_probe, which is const, so
> renesas_sdhi_internal_dmac_dma_ops can be const too.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied for next!

Kind regards
Uffe
>
> ---
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index 6717003..3a82577 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -233,7 +233,7 @@ static void renesas_sdhi_internal_dmac_complete_tasklet_fn(unsigned long arg)
>         host->chan_rx = host->chan_tx = NULL;
>  }
>
> -static struct tmio_mmc_dma_ops renesas_sdhi_internal_dmac_dma_ops = {
> +static const struct tmio_mmc_dma_ops renesas_sdhi_internal_dmac_dma_ops = {
>         .start = renesas_sdhi_internal_dmac_start_dma,
>         .enable = renesas_sdhi_internal_dmac_enable_dma,
>         .request = renesas_sdhi_internal_dmac_request_dma,
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: renesas-sdhi: constify renesas_sdhi_internal_dmac_dma_ops Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-07 22:50 +0200
  Re: [PATCH] mmc: renesas-sdhi: constify renesas_sdhi_internal_dmac_dma_ops Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-08 12:40 +0200

csiph-web