Re: [PATCH] arm64: fix pmem interface definition

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: fix pmem interface definition
Date	Thu, 10 Aug 2017 19:20:02 +0200
Message-ID	<ucZhM-8l-7@gated-at.bofh.it> (permalink)
References	<ucX6i-723-11@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Will Deacon <will.deacon@arm.com>, Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 10 Aug 2017 18:14:34 +0100
X-Original-Message-ID	<20170810171433.obchokljs43rmgk4@armageddon.cambridge.arm.com>
X-Original-References	<20170810145253.2124019-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1708909

Show key headers only | View raw

On Thu, Aug 10, 2017 at 04:52:31PM +0200, Arnd Bergmann wrote:
> Defining the two functions as 'static inline' and exporting them
> leads to the interesting case where we can use the interface
> from loadable modules, but not from built-in drivers, as shown
> in this link failure:
> 
> vers/nvdimm/claim.o: In function `nsio_rw_bytes':
> claim.c:(.text+0x1b8): undefined reference to `arch_invalidate_pmem'
> drivers/nvdimm/pmem.o: In function `pmem_dax_flush':
> pmem.c:(.text+0x11c): undefined reference to `arch_wb_cache_pmem'
> drivers/nvdimm/pmem.o: In function `pmem_make_request':
> pmem.c:(.text+0x5a4): undefined reference to `arch_invalidate_pmem'
> pmem.c:(.text+0x650): undefined reference to `arch_invalidate_pmem'
> pmem.c:(.text+0x6d4): undefined reference to `arch_invalidate_pmem'
> 
> This removes the bogus 'static inline'.
> 
> Fixes: d50e071fdaa3 ("arm64: Implement pmem API support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied. Thanks.

-- 
Catalin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: fix pmem interface definition Arnd Bergmann <arnd@arndb.de> - 2017-08-10 17:00 +0200
  Re: [PATCH] arm64: fix pmem interface definition Robin Murphy <robin.murphy@arm.com> - 2017-08-10 18:40 +0200
  Re: [PATCH] arm64: fix pmem interface definition Catalin Marinas <catalin.marinas@arm.com> - 2017-08-10 19:20 +0200

csiph-web