Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708919

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

From Juergen Gross <jgross@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] paravirt,xen: remove xen_patch()
Date 2017-08-10 19:40 +0200
Message-ID <ucZB8-fd-21@gated-at.bofh.it> (permalink)
References <ucVe9-5GH-1@gated-at.bofh.it> <ucVec-5GH-49@gated-at.bofh.it> <ucYvn-83r-3@gated-at.bofh.it> <ucYvn-83r-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/08/17 18:29, Peter Zijlstra wrote:
> On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote:
>> -ENTRY(xen_irq_enable_direct)
>> -	FRAME_BEGIN
>> -	/* Unmask events */
>> -	movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask
>> -
>> -	/*
>> -	 * Preempt here doesn't matter because that will deal with any
>> -	 * pending interrupts.  The pending check may end up being run
>> -	 * on the wrong CPU, but that doesn't hurt.
>> -	 */
>> -
>> -	/* Test for pending */
>> -	testb $0xff, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_pending
>> -	jz 1f
>> -
>> -2:	call check_events
>> -1:
>> -ENDPATCH(xen_irq_enable_direct)
>> -	FRAME_END
>> -	ret
>> -	ENDPROC(xen_irq_enable_direct)
>> -	RELOC(xen_irq_enable_direct, 2b+1)
> 
> Oh my bad, part of that is still used.
> 
> arch/x86/xen/enlighten_pv.c:            pv_irq_ops.irq_enable = __PV_IS_CALLEE_SAVE(xen_irq_enable_direct);
> 
> It just needs cleanups for the ENDPATCH and such.

Ah yes, of course.


Juergen

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] x86: paravirt related cleanup Juergen Gross <jgross@suse.com> - 2017-08-10 15:00 +0200
  [PATCH 3/3] x86/vsmp: remove vsmp paravirt support Juergen Gross <jgross@suse.com> - 2017-08-10 15:00 +0200
    RE: [PATCH 3/3] x86/vsmp: remove vsmp paravirt support "Shai Fultheim (Shai@ScaleMP.com)" <Shai@ScaleMP.com> - 2017-08-10 17:30 +0200
      Re: [PATCH 3/3] x86/vsmp: remove vsmp paravirt support Juergen Gross <jgross@suse.com> - 2017-08-10 17:40 +0200
  [PATCH 1/3] paravirt,xen: remove xen_patch() Juergen Gross <jgross@suse.com> - 2017-08-10 15:00 +0200
    Re: [PATCH 1/3] paravirt,xen: remove xen_patch() Peter Zijlstra <peterz@infradead.org> - 2017-08-10 18:30 +0200
      Re: [PATCH 1/3] paravirt,xen: remove xen_patch() Juergen Gross <jgross@suse.com> - 2017-08-10 19:40 +0200
    Re: [PATCH 1/3] paravirt,xen: remove xen_patch() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-08-10 18:30 +0200
    Re: [PATCH 1/3] paravirt,xen: remove xen_patch() Peter Zijlstra <peterz@infradead.org> - 2017-08-10 18:30 +0200

csiph-web