Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708787

[PATCH] perf/x86/intel/bts: make bts_pmu static

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The structure bts_pmu is local to the source and do not need to be in
global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'bts_pmu' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/events/intel/bts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/bts.c b/arch/x86/events/intel/bts.c
index 8ae8c5ce3a1f..ddd8d3516bfc 100644
--- a/arch/x86/events/intel/bts.c
+++ b/arch/x86/events/intel/bts.c
@@ -69,7 +69,7 @@ struct bts_buffer {
 	struct bts_phys	buf[0];
 };
 
-struct pmu bts_pmu;
+static struct pmu bts_pmu;
 
 static size_t buf_size(struct page *page)
 {
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/x86/intel/bts: make bts_pmu static Colin King <colin.king@canonical.com> - 2017-08-10 18:00 +0200
  [tip:x86/urgent] x86: Mark various structures and functions as  'static' tip-bot for Colin Ian King <tipbot@zytor.com> - 2017-08-11 15:30 +0200

csiph-web