[PATCH] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

From	Anton Vasilyev <vasilyev@ispras.ru>
Newsgroups	linux.kernel
Subject	[PATCH] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove
Date	2017-08-10 18:00 +0200
Message-ID	<ucY2m-7Ep-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
permorms pri_dai->sec_dai dereference in any case.

The patch adds sec_dai check on Null before derefence at
samsung_i2s_remove().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
 sound/soc/samsung/i2s.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index af3ba4d..6beeea8 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -1382,7 +1382,8 @@ static int samsung_i2s_remove(struct platform_device *pdev)
 	sec_dai = pri_dai->sec_dai;
 
 	pri_dai->sec_dai = NULL;
-	sec_dai->pri_dai = NULL;
+	if (sec_dai)
+		sec_dai->pri_dai = NULL;
 
 	pm_runtime_get_sync(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove Anton Vasilyev <vasilyev@ispras.ru> - 2017-08-10 18:00 +0200
  Re: [PATCH] ASoC: samsung: i2s: Null pointer dereference on  samsung_i2s_remove Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-08-10 18:30 +0200

csiph-web