Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708678

Re: [PATCH RESEND] x86/smpboot: Unbreak CPU0 hotplug

Show all headers | View raw

* Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> Vitaly Kuznetsov <vkuznets@redhat.com> writes:
> 
> > A hang on CPU0 onlining after a preceding offlining is observed. Trace
> > shows that CPU0 is stuck in check_tsc_sync_target() waiting for source
> > CPU to run check_tsc_sync_source() but this never happens. Source CPU,
> > in its turn, is stuck on synchronize_sched() which is called from
> > native_cpu_up() -> do_boot_cpu() -> unregister_nmi_handler().
> >
> > Fix the issue by moving unregister_nmi_handler() from do_boot_cpu() to
> > native_cpu_up() after cpu onlining is done.

Looks like a classic ABBA deadlock, due to the use of synchronize_sched() in 
unregister_nmi_handler(), right?

> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > ---
> > It's been awile since my v1 submission, no comments so far. Resending.
> 
> Sorry, but 
> 
> ping?
> 
> I haven't received a single comment on this since the initial submission
> on June, 26 - is it so bad? :-)

So the fix looks good to me at first sight, but wanted to wait for Thomas to ack 
it - once he gets back from vacation.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] x86/smpboot: Unbreak CPU0 hotplug Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-03 13:00 +0200
  Re: [PATCH RESEND] x86/smpboot: Unbreak CPU0 hotplug Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-10 14:10 +0200
    Re: [PATCH RESEND] x86/smpboot: Unbreak CPU0 hotplug Ingo Molnar <mingo@kernel.org> - 2017-08-10 16:30 +0200
      Re: [PATCH RESEND] x86/smpboot: Unbreak CPU0 hotplug Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-08-10 17:00 +0200
  [tip:x86/urgent] x86/smpboot: Unbreak CPU0 hotplug tip-bot for Vitaly Kuznetsov <tipbot@zytor.com> - 2017-08-10 18:50 +0200

csiph-web