Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708444

Re: [PATCH] Subject:drivers:staging:media:atomisp:

From Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups linux.kernel
Subject Re: [PATCH] Subject:drivers:staging:media:atomisp:
Date 2017-08-10 13:10 +0200
Message-ID <ucTvJ-4OI-35@gated-at.bofh.it> (permalink)
References <ucS6C-3LT-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Harold,

Please use a better subject line.

On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote:
> Fix Warning from checkpatch.pl 
> Block comments use * on subsequent lines
> 
> Signed-off-by: Harold Gomez <haroldgmz11@gmail.com>
> ---
>  drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
> index 9d6ce36..ac1aa96 100644
> --- a/drivers/staging/media/atomisp/i2c/ap1302.c
> +++ b/drivers/staging/media/atomisp/i2c/ap1302.c
> @@ -158,8 +158,9 @@ static struct ap1302_context_info context_info[] = {
>  };
>  
>  /* This array stores the description list for metadata.
> -   The metadata contains exposure settings and face
> -   detection results. */
> + * The metadata contains exposure settings and face
> + * detection results.
> + */

/*
 * Multi-line comments
 * look like this.
 */

>  static u16 ap1302_ss_list[] = {
>  	0xb01c, /* From 0x0186 with size 0x1C are exposure settings. */
>  	0x0186,
> -- 
> 2.1.4
> 

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] Subject:drivers:staging:media:atomisp: Harold Gomez <haroldgmz11@gmail.com> - 2017-08-10 11:40 +0200
  Re: [PATCH] Subject:drivers:staging:media:atomisp: Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-10 13:10 +0200

csiph-web