Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708343

Re: [v2,06/20] brcm80211: constify usb_device_id

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [v2,06/20] brcm80211: constify usb_device_id
Date 2017-08-10 11:00 +0200
Message-ID <ucRtU-323-25@gated-at.bofh.it> (permalink)
References <ucC1Q-1i5-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Does not apply to wireless-drivers-next:

error: Failed to merge in the changes.
Applying: brcm80211: constify usb_device_id
Using index info to reconstruct a base tree...
M	drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
CONFLICT (content): Merge conflict in drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
Patch failed at 0001 brcm80211: constify usb_device_id
The copy of the patch that failed is found in: .git/rebase-apply/patch

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/9890985/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2 06/20] brcm80211: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 18:30 +0200
  Re: [v2,06/20] brcm80211: constify usb_device_id Kalle Valo <kvalo@codeaurora.org> - 2017-08-10 11:00 +0200

csiph-web