Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

From	Yingjoe Chen <yingjoe.chen@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
Date	2017-08-10 10:10 +0200
Message-ID	<ucQHv-2LF-1@gated-at.bofh.it> (permalink)
References	<ucLot-7NK-3@gated-at.bofh.it> <ucLot-7NK-1@gated-at.bofh.it> <ucQ4O-2jh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-08-10 at 15:22 +0800, Jun Gao wrote:
> On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote:
> > From: Jun Gao <jun.gao@mediatek.com>
> > 
> > Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> > MT7622 limits message numbers to 255, and does not support 4GB
> > DMA mode.
> > 
> 
> These two resend patches only modify commit message.
> Thanks!
> 
> Jun

Looks good to me, so for new version:
Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

Joe.C


> 
> > Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> > ---
> >  drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> > index 9bedf0b..2c7f847 100644
> > --- a/drivers/i2c/busses/i2c-mt65xx.c
> > +++ b/drivers/i2c/busses/i2c-mt65xx.c
> > @@ -172,6 +172,14 @@ struct mtk_i2c {
> >  	.max_comb_2nd_msg_len = 31,
> >  };
> >  
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > +	.max_num_msgs = 255,
> > +	.max_write_len = 65535,
> > +	.max_read_len = 65535,
> > +	.max_comb_1st_msg_len = 65535,
> > +	.max_comb_2nd_msg_len = 65535,
> > +};
> > +
> >  static const struct mtk_i2c_compatible mt6577_compat = {
> >  	.quirks = &mt6577_i2c_quirks,
> >  	.pmic_i2c = 0,
> > @@ -190,6 +198,15 @@ struct mtk_i2c {
> >  	.support_33bits = 0,
> >  };
> >  
> > +static const struct mtk_i2c_compatible mt7622_compat = {
> > +	.quirks = &mt7622_i2c_quirks,
> > +	.pmic_i2c = 0,
> > +	.dcm = 1,
> > +	.auto_restart = 1,
> > +	.aux_len_reg = 1,
> > +	.support_33bits = 0,
> > +};
> > +
> >  static const struct mtk_i2c_compatible mt8173_compat = {
> >  	.pmic_i2c = 0,
> >  	.dcm = 1,
> > @@ -201,6 +218,7 @@ struct mtk_i2c {
> >  static const struct of_device_id mtk_i2c_of_match[] = {
> >  	{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> >  	{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> > +	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> >  	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> >  	{}
> >  };
> 
> 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao <jun.gao@mediatek.com> - 2017-08-10 04:30 +0200
  Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for  MediaTek MT7622 Jun Gao <jun.gao@mediatek.com> - 2017-08-10 09:30 +0200
    Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for  MediaTek MT7622 Yingjoe Chen <yingjoe.chen@mediatek.com> - 2017-08-10 10:10 +0200

csiph-web