[PATCH] VFS: lookup path of "-o remount" the same way as "umount"

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	NeilBrown <neilb@suse.com>
Newsgroups	linux.kernel
Subject	[PATCH] VFS: lookup path of "-o remount" the same way as "umount"
Date	Thu, 10 Aug 2017 08:40:03 +0200
Message-ID	<ucPir-1NU-21@gated-at.bofh.it> (permalink)
X-Original-To	Al Viro <viro@zeniv.linux.org.uk>
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	75
Organization	linux.* mail to news gateway
X-Original-Cc	Linux NFS Mailing List <linux-nfs@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 10 Aug 2017 16:30:36 +1000
X-Original-Message-ID	<87shh0q6ib.fsf@notabene.neil.brown.name>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1708245

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

"mount -o remount" does not need to validate the target directory
for the same reasons that "umount" doesn't.  It just needs to
find the mountpoint and verify it is a mountpount.

So change do_mount() to use user_path_mountpoint_at() in the
MS_REMOUNT case.

This means that mount(.., MS_REMOUNT|MS_RO, ..) on a network
attached filesystem will only access the network if there
is data to be written out.  This reduces the chance of a hang
when the network is down.

Systemd-shutdown currently calls
   mount(NULL, path, NULL, MS_REMOUNT|MS_RDONLY, ...);
   umount2(path, 0);

which is not unreasonable for local filesystems which may still
be in use, but causes a hang for NFS filesystems which have not
been unmounted.

Note that this change does not affect
   /usr/bin/mount -o remount,ro ...
as that currently calls "lstat()" on the mount point.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 fs/namespace.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index f8893dc6a989..31ded3a1cdff 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2718,7 +2718,10 @@ long do_mount(const char *dev_name, const char __user *dir_name,
 		((char *)data_page)[PAGE_SIZE - 1] = 0;
 
 	/* ... and get the mountpoint */
-	retval = user_path(dir_name, &path);
+	if (flags & MS_REMOUNT)
+		retval = user_path_mountpoint_at(AT_FDCWD, dir_name, 0, &path);
+	else
+		retval = user_path(dir_name, &path);
 	if (retval)
 		return retval;
 
-- 
2.12.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] VFS: lookup path of "-o remount" the same way as "umount" NeilBrown <neilb@suse.com> - 2017-08-10 08:40 +0200

csiph-web