Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1708220

Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence

From Vignesh R <vigneshr@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence
Date 2017-08-10 07:30 +0200
Message-ID <ucOcF-1a6-5@gated-at.bofh.it> (permalink)
References <u9xrH-79w-3@gated-at.bofh.it> <u9xrI-79w-19@gated-at.bofh.it> <ucJd0-6lV-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On Thursday 10 August 2017 05:38 AM, Rob Herring wrote:
> On Tue, Aug 01, 2017 at 10:24:28AM +0530, Vignesh R wrote:
>> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access
>> Controller programming sequence, a delay equal to couple QSPI master
>> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and
>> writing data to the flash. Add a new compatible to handle the couple of
>> cycles of delay required in the indirect write sequence, since this
>> delay is specific to TI 66AK2G SoC.
>>
>> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>>  Documentation/devicetree/bindings/mtd/cadence-quadspi.txt |  1 +
>>  drivers/mtd/spi-nor/cadence-quadspi.c                     | 13 +++++++++++++
>>  2 files changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
>> index f248056da24c..fdd511a83511 100644
>> --- a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
>> +++ b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
>> @@ -2,6 +2,7 @@
>>  
>>  Required properties:
>>  - compatible : Should be "cdns,qspi-nor".
>> +	       Should be "ti,k2g-qspi" for TI 66AK2G platform.
> 
> Also, this doesn't indicate that "cdns,qspi-nor" is a fallback as you 
> have in the dts files. Reformat to 1 valid combination per line.
> 

Agreed, will fix it in v2.

-- 
Regards
Vignesh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence Vignesh R <vigneshr@ti.com> - 2017-08-01 07:00 +0200
  Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write  sequence Rob Herring <robh@kernel.org> - 2017-08-10 02:10 +0200
    Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write  sequence Vignesh R <vigneshr@ti.com> - 2017-08-10 07:30 +0200
  Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write  sequence Rob Herring <robh@kernel.org> - 2017-08-10 02:10 +0200
    Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write  sequence Vignesh R <vigneshr@ti.com> - 2017-08-10 07:30 +0200

csiph-web