Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1708214
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] memory: mtk-smi: Handle return value of clk_prepare_enable |
| Date | Thu, 10 Aug 2017 07:20:01 +0200 |
| Message-ID | <ucO2Z-16P-5@gated-at.bofh.it> (permalink) |
| X-Original-To | matthias.bgg@gmail.com, iommu@lists.linux-foundation.org, joro@8bytes.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uGDeiLKMyPmZAMJO/boCF8vTbvRWXPJ76kxcW6Gra1M=; b=eHfMhvxlKx+WjYVB9BlB0wxStwvbndKeygoKcNTkyQEG6SYP0NJr/a0o24MnYfiv0g 8oWGz5EcTHQxx0lwLya3A+o5YTozDWJZqk4+Rj1wMI5BHVyEvfJn5i6/ONnYwsNlr6PO oF4tBGN9nVF5kXkspUPvKbv5zCUu856dbt5mOmsjfBZlvSnTMAdrvc4nuqHqJXHG3Lsq f6IesBjYPyAJunzNKQ1bFg5ml/CFx5l0sL01Oh3jSX6eVmMc66BzSxL3cH5D3g8ymDLX fIYZtTxIV+g4iRb8+dH0bFCHeBoiSVnaQaE1TZaCdYIecAAEfQ/1K09xEbSF2xtwN0xR iSDA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uGDeiLKMyPmZAMJO/boCF8vTbvRWXPJ76kxcW6Gra1M=; b=YHf2dFK0tlO2QDodtUckg94cySXFSrJdbn5nDjNF8MLIcya2ySJL9E0Jeq01WwXYvJ 97A1ArLmMs2oBsIO6Z1BZBaX/qyIUkak5hy/4JsekilI08/CqdtY9pvrUQnb4Fq8AjuY 1ftYKUb3t44ov4oGaVvd12+gC73PSSASzj3wBj6OJUCy7tMRV48cG0LYXgv+6YK9R6ik bFpl0R5TsKvwX2POZ3UVANuOxkoTEZ9hv7fZkrr7uc5jGzMcRadTi+WZeTJVVBPlATZq kgdYbgaKmMLXSyzTIQmM+NG75pQugdixKc+tfVDcddvYidGG+v3ggKW2fCjXSwS1Zur0 wJKA== |
| X-Gm-Message-State | AHYfb5iHNkXPwMMgKEDdQ8412I644zDf0YSO4g7Tz91hbNrfi9NYT+T1 qbGf962afgYPQg== |
| X-Received | by 10.84.218.136 with SMTP id r8mr11606002pli.111.1502342282368; Wed, 09 Aug 2017 22:18:02 -0700 (PDT) |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 10 Aug 2017 10:47:32 +0530 |
| X-Original-Message-ID | <daeed02ff9e257286bbae9e4e496e40e4c5480c5.1502341483.git.arvind.yadav.cs@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1708214 |
Show key headers only | View raw
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2:
Rebase patch[1]https://lkml.org/lkml/2017/8/3/968
and apply this change. Otherwise will merge conflict.
drivers/memory/mtk-smi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 2b798bb..583fb8d 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -315,6 +315,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
struct mtk_smi *common;
struct resource *res;
enum mtk_smi_gen smi_gen;
+ int ret;
if (!dev->pm_domain)
return -EPROBE_DEFER;
@@ -349,7 +350,9 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
if (IS_ERR(common->clk_async))
return PTR_ERR(common->clk_async);
- clk_prepare_enable(common->clk_async);
+ ret = clk_prepare_enable(common->clk_async);
+ if (ret)
+ return ret;
}
pm_runtime_enable(dev);
platform_set_drvdata(pdev, common);
--
1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v2] memory: mtk-smi: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-10 07:20 +0200
csiph-web