Re: [PATCH -mm -v4 1/5] mm, swap: Add swap readahead hit statistics

From	"Huang\, Ying" <ying.huang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -mm -v4 1/5] mm, swap: Add swap readahead hit statistics
Date	2017-08-10 01:20 +0200
Message-ID	<ucIqB-5FE-1@gated-at.bofh.it> (permalink)
References	<ubJ5o-4ag-5@gated-at.bofh.it> <ubJ5o-4ag-21@gated-at.bofh.it> <ucHbc-4yf-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andrew Morton <akpm@linux-foundation.org> writes:

> On Mon,  7 Aug 2017 13:40:34 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> The statistics for total readahead pages and total readahead hits are
>> recorded and exported via the following sysfs interface.
>> 
>> /sys/kernel/mm/swap/ra_hits
>> /sys/kernel/mm/swap/ra_total
>> 
>> With them, the efficiency of the swap readahead could be measured, so
>> that the swap readahead algorithm and parameters could be tuned
>> accordingly.
>> 
>> ...
>>
>> --- a/include/linux/vm_event_item.h
>> +++ b/include/linux/vm_event_item.h
>> @@ -106,6 +106,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
>>  		VMACACHE_FIND_HITS,
>>  		VMACACHE_FULL_FLUSHES,
>>  #endif
>> +		SWAP_RA,
>> +		SWAP_RA_HIT,
>>  		NR_VM_EVENT_ITEMS
>>  };
>
> swap_state.o isn't even compiled if CONFIG_SWAP=n so there doesn't seem
> much point in displaying these?

Oh, Yes!  Thanks for pointing this out.

Best Regards,
Huang, Ying

> --- a/include/linux/vm_event_item.h~mm-swap-add-swap-readahead-hit-statistics-fix
> +++ a/include/linux/vm_event_item.h
> @@ -106,8 +106,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS
>  		VMACACHE_FIND_HITS,
>  		VMACACHE_FULL_FLUSHES,
>  #endif
> +#ifdef CONFIG_SWAP
>  		SWAP_RA,
>  		SWAP_RA_HIT,
> +#endif
>  		NR_VM_EVENT_ITEMS
>  };
>  
> --- a/mm/vmstat.c~mm-swap-add-swap-readahead-hit-statistics-fix
> +++ a/mm/vmstat.c
> @@ -1098,9 +1098,10 @@ const char * const vmstat_text[] = {
>  	"vmacache_find_hits",
>  	"vmacache_full_flushes",
>  #endif
> -
> +#ifdef CONFIG_SWAP
>  	"swap_ra",
>  	"swap_ra_hit",
> +#endif
>  #endif /* CONFIG_VM_EVENTS_COUNTERS */
>  };
>  #endif /* CONFIG_PROC_FS || CONFIG_SYSFS || CONFIG_NUMA */
> _

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -mm -v4 0/5] mm, swap: VMA based swap readahead "Huang, Ying" <ying.huang@intel.com> - 2017-08-07 07:50 +0200
  [PATCH -mm -v4 1/5] mm, swap: Add swap readahead hit statistics "Huang, Ying" <ying.huang@intel.com> - 2017-08-07 07:50 +0200
    Re: [PATCH -mm -v4 1/5] mm, swap: Add swap readahead hit statistics Andrew Morton <akpm@linux-foundation.org> - 2017-08-10 00:00 +0200
      Re: [PATCH -mm -v4 1/5] mm, swap: Add swap readahead hit statistics "Huang\, Ying" <ying.huang@intel.com> - 2017-08-10 01:20 +0200

csiph-web