Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

From	Steve deRosier <derosier@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 02/20] ath6kl: constify usb_device_id
Date	2017-08-09 23:10 +0200
Message-ID	<ucGoN-4hg-3@gated-at.bofh.it> (permalink)
References	<ucC1P-1i5-5@gated-at.bofh.it> <ucC1Q-1i5-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 9, 2017 at 9:23 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
>               Re-submitting wireless separately.
>
>  drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
> index 9da3594..4defb7a 100644
> --- a/drivers/net/wireless/ath/ath6kl/usb.c
> +++ b/drivers/net/wireless/ath/ath6kl/usb.c
> @@ -1201,7 +1201,7 @@ static int ath6kl_usb_pm_resume(struct usb_interface *interface)
>  #endif
>
>  /* table of devices that work with this driver */
> -static struct usb_device_id ath6kl_usb_ids[] = {
> +static const struct usb_device_id ath6kl_usb_ids[] = {
>         {USB_DEVICE(0x0cf3, 0x9375)},
>         {USB_DEVICE(0x0cf3, 0x9374)},
>         { /* Terminating entry */ },
> --
> 2.7.4
>

Looks good. Also builds and works properly.

Reviewed-by: Steve deRosier <derosier@gmail.com>
Tested-by: Steve deRosier <derosier@gmail.com>

- Steve

Thread

[PATCH v2 00/20] constify wireless usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 18:30 +0200
  [PATCH v2 01/20] ar5523: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 18:30 +0200
    Re: [v2,01/20] ar5523: constify usb_device_id Kalle Valo <kvalo@codeaurora.org> - 2017-08-10 11:00 +0200
  [PATCH v2 02/20] ath6kl: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 18:30 +0200
    Re: [PATCH v2 02/20] ath6kl: constify usb_device_id Steve deRosier <derosier@gmail.com> - 2017-08-09 23:10 +0200
    Re: [v2,02/20] ath6kl: constify usb_device_id Kalle Valo <kvalo@qca.qualcomm.com> - 2017-08-11 16:10 +0200

csiph-web