Re: [PATCH] iio: trigger: stm32-timer: fix get trigger mode

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: trigger: stm32-timer: fix get trigger mode
Date	2017-08-09 16:50 +0200
Message-ID	<ucAt5-fu-35@gated-at.bofh.it> (permalink)
References	<uakC7-6qh-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 3 Aug 2017 11:22:17 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> Fix reading trigger mode, when other bit-fields are set. SMCR register
> value must be masked to read SMS (slave mode selection) only.
> 
> Fixes: 9eba381 ("iio: make stm32 trigger driver use
> INDIO_HARDWARE_TRIGGERED mode")
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the fixes-togreg branch of iio.git.

THanks,

Jonathan
> ---
>  drivers/iio/trigger/stm32-timer-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 14e6eb0..25ad6ab 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -485,7 +485,7 @@ static int stm32_get_trigger_mode(struct iio_dev *indio_dev,
>  
>  	regmap_read(priv->regmap, TIM_SMCR, &smcr);
>  
> -	return smcr == TIM_SMCR_SMS ? 0 : -EINVAL;
> +	return (smcr & TIM_SMCR_SMS) == TIM_SMCR_SMS ? 0 : -EINVAL;
>  }
>  
>  static const struct iio_enum stm32_trigger_mode_enum = {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: trigger: stm32-timer: fix get trigger mode Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-03 11:30 +0200
  Re: [PATCH] iio: trigger: stm32-timer: fix get trigger mode Jonathan Cameron <jic23@kernel.org> - 2017-08-09 16:50 +0200

csiph-web