Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1707412

Re: f_hid.c conversion to the new function interface and crash due to race

From Variksla <variksla@gmail.com>
Newsgroups linux.kernel
Subject Re: f_hid.c conversion to the new function interface and crash due to race
Date 2017-08-09 17:20 +0200
Message-ID <ucAW6-Gt-31@gated-at.bofh.it> (permalink)
References <ucuQG-4Bw-15@gated-at.bofh.it> <ucvWq-5qB-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



> On Aug 9, 2017, at 2:56 AM, Felipe Balbi <felipe.balbi@linux.intel.com> wrote:

Thanks for replying.
> 
> 
> Hi,
> 
> noman pouigt <variksla@gmail.com> writes:
>> Hello,
>> 
>> I am currently using 3.18 linux kernel and getting below
> 
> return -EKERNELTOOOLD;
> 
> Sorry, you're on your own. You should ask for support from whoever
> forces you to use 3.18 kernel.

I have updated f_hid.c file to latest kernel though as I knew it would be too much to ask to get support for old code.

I am just not sure about how to instantiate the function driver as earlier f_fs was instantiating the hid driver. However, after hid got converted to new function driver who is responsible for calling setup, bind and unbind functions in f_hid.c ?

Below is the glue code in android.c.
drivers/usb/gadget/android.c
static struct android_usb_function hid_function = {
       .name           = "hid",
       .init           = hid_function_init,
       .cleanup        = hid_function_cleanup,
       .bind_config    = hid_function_bind_config,
       .attributes     = hid_function_attributes,
};

Is there something similar in new function driver in upstream kernel?
> 
> -- 
> balbi

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

f_hid.c conversion to the new function interface and crash due to race noman pouigt <variksla@gmail.com> - 2017-08-09 10:50 +0200
  Re: f_hid.c conversion to the new function interface and crash due to race Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-09 12:00 +0200
    Re: f_hid.c conversion to the new function interface and crash due to race Variksla <variksla@gmail.com> - 2017-08-09 17:20 +0200
      Re: f_hid.c conversion to the new function interface and crash due to race Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-10 11:10 +0200

csiph-web