Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1706267

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property
Date 2017-08-08 11:50 +0200
Message-ID <uc9jb-69T-5@gated-at.bofh.it> (permalink)
References <ubVSX-4zQ-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, Aug 07, 2017 at 09:20:05PM +0200, Hans de Goede wrote:
> On 07-08-17 17:41, Mark Brown wrote:

> > I2C has a perfectly good platform_data pointer in the board info for
> > this stuff.

> True, so you are suggesting that I define a bq24190_platform_data
> struct with a regulator_init_data pointer in there I guess?

Yes.  

> I don't think the power-supply maintainers will be enthusiastic
> about this (hi Sebastian). But that does make sense and is
> actually a good idea for tackling the problem of regulator_init_data.

Why not?  This is just really standard usage of platform data.

> Would extending the struct regulator_map with a const char *provider_name:

> struct regulator_map {
>         struct list_head list;
>         const char *dev_name;   /* The dev_name() for the consumer */
>         const char *supply;
>         struct regulator_dev *regulator;
> 	const char *provider;	/* The dev_name() for the regulator parent-dev */
> };

Please don't invent new terminology like this.  Just call it a regulator
name.

> Alternatively the entry could additionally contain a provider_supply_name
> so that we can make arbitrary consumer-dev-name + consumer-supply-name
> provider-dev-name + provider-supply-name matches. That would probably
> be more flexible then requiring the supply name to match.

I'm sorry but I can't follow what you mean here.  What do you mean by
"provider_supply_name"?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/18] Hookup typec power-negotation to the PMIC and charger Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
  [PATCH 12/18] power: supply: Add power_supply_set_input_current_limit_from_supplier helper Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
  [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost converter as regulator Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
    Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost  converter as regulator Tony Lindgren <tony@atomide.com> - 2017-08-08 06:20 +0200
    Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost  converter as regulator Liam Breck <liam@networkimprov.net> - 2017-08-08 10:50 +0200
      Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost  converter as regulator Hans de Goede <hdegoede@redhat.com> - 2017-08-08 11:10 +0200
        Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost  converter as regulator Liam Breck <liam@networkimprov.net> - 2017-08-08 21:00 +0200
          Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost  converter as regulator Hans de Goede <hdegoede@redhat.com> - 2017-08-08 23:10 +0200
  [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
    Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Guenter Roeck <linux@roeck-us.net> - 2017-08-06 16:40 +0200
      Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-06 17:00 +0200
        Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Guenter Roeck <linux@roeck-us.net> - 2017-08-06 17:30 +0200
      Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-06 17:50 +0200
        Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Mark Brown <broonie@kernel.org> - 2017-08-07 13:20 +0200
          Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-07 16:50 +0200
            Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Mark Brown <broonie@kernel.org> - 2017-08-07 17:50 +0200
              Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-07 21:30 +0200
                Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Mark Brown <broonie@kernel.org> - 2017-08-08 11:50 +0200
                Re: [PATCH 10/18] staging: typec: fusb302: Add support for  fcs,vbus-regulator-name device-property Hans de Goede <hdegoede@redhat.com> - 2017-08-08 23:00 +0200
  [PATCH 14/18] power: supply: bq24190_charger: Add input_current_limit property Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
  [PATCH 09/18] staging: typec: fusb302: Use tcpm_set_current_limit_psy Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
    Re: [PATCH 09/18] staging: typec: fusb302: Use  tcpm_set_current_limit_psy Guenter Roeck <linux@roeck-us.net> - 2017-08-06 16:30 +0200
  [PATCH 05/18] staging: typec: fusb302: Set max supply voltage to 5V Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
  [PATCH 03/18] staging: typec: tcpm: Split tcpm code into tcpm-core.c and tcpm-helpers.c Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:40 +0200
  [PATCH 02/18] staging: typec: tcpm: Add extcon helper functions for USB2 current limit detect Hans de Goede <hdegoede@redhat.com> - 2017-08-06 14:50 +0200
    Re: [PATCH 02/18] staging: typec: tcpm: Add extcon helper functions  for USB2 current limit detect Guenter Roeck <linux@roeck-us.net> - 2017-08-06 16:10 +0200

csiph-web