[PATCH] IB/core: fix memory leak on ah on error return path

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] IB/core: fix memory leak on ah on error return path
Date	2017-08-08 12:20 +0200
Message-ID	<uc9Me-6Rb-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

When dmac is NULL, ah is not being freed on the error return path. Fix
this by kfree'ing it.

Detected by CoverityScan, CID#1452636 ("Resource Leak")

Fixes: d8966fcd4c25 ("IB/core: Use rdma_ah_attr accessor functions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/hns/hns_roce_ah.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_ah.c b/drivers/infiniband/hw/hns/hns_roce_ah.c
index f78a733a63ec..d545302b8ef8 100644
--- a/drivers/infiniband/hw/hns/hns_roce_ah.c
+++ b/drivers/infiniband/hw/hns/hns_roce_ah.c
@@ -64,8 +64,10 @@ struct ib_ah *hns_roce_create_ah(struct ib_pd *ibpd,
 	} else {
 		u8 *dmac = rdma_ah_retrieve_dmac(ah_attr);
 
-		if (!dmac)
+		if (!dmac) {
+			kfree(ah);
 			return ERR_PTR(-EINVAL);
+		}
 		memcpy(ah->av.mac, dmac, ETH_ALEN);
 	}
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] IB/core: fix memory leak on ah on error return path Colin King <colin.king@canonical.com> - 2017-08-08 12:20 +0200
  Re: [PATCH] IB/core: fix memory leak on ah on error return path Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-08 12:30 +0200
    Re: [PATCH] IB/core: fix memory leak on ah on error return path Colin Ian King <colin.king@canonical.com> - 2017-08-08 12:30 +0200
      Re: [PATCH] IB/core: fix memory leak on ah on error return path Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-08 15:00 +0200
        RE: [PATCH] IB/core: fix memory leak on ah on error return path Parav Pandit <parav@mellanox.com> - 2017-08-08 21:50 +0200

csiph-web