Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1706287
| Path | csiph.com!goblin3!goblin.stu.neva.ru!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Lee Jones <lee.jones@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices |
| Date | Tue, 08 Aug 2017 12:10:02 +0200 |
| Message-ID | <uc9Cy-6yS-17@gated-at.bofh.it> (permalink) |
| References | <u8U6Z-7Fp-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=F/xTl8Ra7lzjs+xbSphRSEeX0kZ8d2dNUCCGv8Bj9Go=; b=QGR0dvgAUMuUzhAAmcJVSVR36z+t0TLBNkDin4EVDn95udGBQNCG7NOqllThTzd8/p lIvTEIsQrdpsgEixuhU5Qox6O2u79U1eFj90TAnWdDE4dYcety74VOTeetsoLo9e5msb yC8CtteGXtYP4ajkJ+8vquPQFVkqyJ8IsvcUM= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=F/xTl8Ra7lzjs+xbSphRSEeX0kZ8d2dNUCCGv8Bj9Go=; b=ELXNLezer3PbOHIsB2RN02ruaisqx/qP40/wgMagi2LLBeIVknKlQJXF7r8LyNAoeC PAsapmvy8zFbM3JFQypy7fFM+sA4NZr0NLCBs8D8Vzn3gBzr2VDTANScHy1TMfVScUmc JTr0PfhaFBNsjsPSBHAWvjHHBwfRYuVg5axAu7RQkNAycUi1DcAGWs2GyJFKocni82Bn 7Z1qe86x3afeb5Ig7eD63mEIb4OMsHd2J9F+k+iNhsgChiU02I+NNx5Z/HemLHo4QyHI SPpDKjV4J4dDLlsoqR5Vnm59SVsc71zfRFy7nhelZFBcG9JeAy4q+LWJYgjVUkIlguy/ uMSg== |
| X-Gm-Message-State | AHYfb5jm1k/HqiLoUztfl5b3fz1HWE6e3juGqxnrhd4dNqxgNSZmf9Kc k0JRDZjmXG+J9qxUz4wJCQ== |
| X-Received | by 10.223.176.148 with SMTP id i20mr2225269wra.165.1502186587314; Tue, 08 Aug 2017 03:03:07 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| Content-Transfer-Encoding | 8bit |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 35 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Keerthy <j-keerthy@ti.com>, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 8 Aug 2017 11:03:04 +0100 |
| X-Original-Message-ID | <20170808100304.fdiu35jzx5jbv5eb@dell> |
| X-Original-References | <20170730105815.26728-1-axel.lin@ingics.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1706287 |
Show key headers only | View raw
On Sun, 30 Jul 2017, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp87565.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>
> i2c_set_clientdata(client, lp87565);
>
> - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> - return ret;
> + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> + lp87565_cells, ARRAY_SIZE(lp87565_cells),
> + NULL, 0, NULL);
> }
>
> static const struct i2c_device_id lp87565_id_table[] = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:10 +0200
csiph-web