Re: [PATCH] memory: mtk-smi: Handle return value of clk_prepare_enable

Path	csiph.com!goblin1!goblin.stu.neva.ru!feeders.as203319.net!feeder01.as203319.net!aioe.org!bofh.it!news.nic.it!robomod
From	Honghui Zhang <honghui.zhang@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memory: mtk-smi: Handle return value of clk_prepare_enable
Date	Tue, 08 Aug 2017 10:40:02 +0200
Message-ID	<uc8ds-5nN-21@gated-at.bofh.it> (permalink)
References	<uc5pf-3kw-3@gated-at.bofh.it> <uc5pf-3kw-1@gated-at.bofh.it>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.2.3-0ubuntu6
Content-Transfer-Encoding	7bit
MIME-Version	1.0
X-Mtk	N
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	<matthias.bgg@gmail.com>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 8 Aug 2017 16:35:19 +0800
X-Original-Message-ID	<1502181319.24341.38.camel@mtksdaap41>
X-Original-References	<472bce58da459a7c64d0ad1cd39b74fa0fcf77f1.1502167256.git.arvind.yadav.cs@gmail.com> <2c1de1862ce9fdefe7653706915c146038b12c4c.1502167256.git.arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1706158

Show key headers only | View raw

On Tue, 2017-08-08 at 11:06 +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---

Hi, Arvind,
please rebase this to my latest patchset[1], it's been applied by Joerg.
And please send this one to Joerg and iommu mail list.

otherwise:
Acked-by: Honghui Zhang <honghui.zhang@mediatek.com>

[1]https://lkml.org/lkml/2017/8/3/968

Thanks.
>  drivers/memory/mtk-smi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index 4afbc41..edf36f0 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -321,6 +321,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
>  	struct resource *res;
>  	const struct of_device_id *of_id;
>  	enum mtk_smi_gen smi_gen;
> +	int ret;
>  
>  	if (!dev->pm_domain)
>  		return -EPROBE_DEFER;
> @@ -359,7 +360,9 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
>  		if (IS_ERR(common->clk_async))
>  			return PTR_ERR(common->clk_async);
>  
> -		clk_prepare_enable(common->clk_async);
> +		ret = clk_prepare_enable(common->clk_async);
> +		if (ret)
> +			return ret;
>  	}
>  	pm_runtime_enable(dev);
>  	platform_set_drvdata(pdev, common);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] memory: mtk-smi: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 07:40 +0200
  Re: [PATCH] memory: mtk-smi: Handle return value of  clk_prepare_enable Honghui Zhang <honghui.zhang@mediatek.com> - 2017-08-08 10:40 +0200

csiph-web