Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706133

Re: [PATCH v1 5/6] zram: remove zram_rw_page

Show all headers | View raw

Hi Sergey,

On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote:
> On (08/08/17 15:50), Minchan Kim wrote:
> > With on-stack-bio, rw_page interface doesn't provide a clear performance
> > benefit for zram and surely has a maintenance burden, so remove the
> > last user to remove rw_page completely.
> 
> OK, never really liked it, I think we had that conversation before.
> 
> as far as I remember, zram_rw_page() was the reason we had to do some
> tricks with init_lock to make lockdep happy. may be now we can "simplify"
> the things back.

I cannot remember. Blame my brain. ;-)

Anyway, it's always welcome to make thing simple.
Could you send a patch after settle down this patchset?

> 
> 
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Thanks for the review!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/6] Remove rw_page Minchan Kim <minchan@kernel.org> - 2017-08-08 09:00 +0200
  [PATCH v1 5/6] zram: remove zram_rw_page Minchan Kim <minchan@kernel.org> - 2017-08-08 09:00 +0200
    Re: [PATCH v1 5/6] zram: remove zram_rw_page Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-08 09:10 +0200
      Re: [PATCH v1 5/6] zram: remove zram_rw_page Minchan Kim <minchan@kernel.org> - 2017-08-08 10:20 +0200
        Re: [PATCH v1 5/6] zram: remove zram_rw_page Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-08 10:30 +0200
          Re: [PATCH v1 5/6] zram: remove zram_rw_page Matthew Wilcox <willy@infradead.org> - 2017-08-08 17:50 +0200

csiph-web