Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver
Date	2017-08-08 03:10 +0200
Message-ID	<uc1bX-7m-1@gated-at.bofh.it> (permalink)
References	<uamaR-7y1-3@gated-at.bofh.it> <ubPDQ-8gK-15@gated-at.bofh.it> <ubQJz-xP-5@gated-at.bofh.it> <ubSil-1Ys-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

2017-08-08 0:37 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>:
> On Mon, Aug 7, 2017 at 3:50 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>
>> Adding "interrupts" property in DT causes
>> of_pupulate_default_populate() to assign virtual IRQ numbers
>> before driver probing.  So it does not work well with IRQ domain hierarchy.
>
> I think I heard some noise about this the week before.
>
>> For pinctrl/stm32/pinctrl-stm32.c,
>> I do not see "interrupts", so it just straight maps the irq numbers.
>
> I think OMAP and DaVinci does someting similar too. This is from a recent
> DaVinci patch from Keerthy:
>
> +Example for 66AK2G:
> +
> +gpio0: gpio@2603000 {
> +       compatible = "ti,k2g-gpio", "ti,keystone-gpio";
> +       reg = <0x02603000 0x100>;
> +       gpio-controller;
> +       #gpio-cells = <2>;
> +       interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
> +                       <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
> +       interrupt-controller;
> +       #interrupt-cells = <2>;
> +       ti,ngpio = <144>;
> +       ti,davinci-gpio-unbanked = <0>;
> +       clocks = <&k2g_clks 0x001b 0x0>;
> +       clock-names = "gpio";
> +};
>
>
> That looks fairly similar.
>

I do not think so.


I do not see .alloc hook in drivers/gpio/gpio-davinci.c
so this driver is unrelated to IRQ domain hierarchy.






-- 
Best Regards
Masahiro Yamada

Thread

[PATCH] gpio: uniphier: add UniPhier GPIO controller driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-03 13:10 +0200
  Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 14:50 +0200
    Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-07 16:00 +0200
      Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 17:40 +0200
        Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-08 03:10 +0200
          Re: [PATCH] gpio: uniphier: add UniPhier GPIO controller driver Keerthy <j-keerthy@ti.com> - 2017-08-08 06:20 +0200

csiph-web