Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1704770

[PATCH 2/8] Input: xpad: constify usb_device_id.

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/8] Input: xpad: constify usb_device_id.
Date Sun, 06 Aug 2017 09:50:02 +0200
Message-ID <ubotY-7MP-13@gated-at.bofh.it> (permalink)
References <ubotX-7MP-11@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/TW7QwjOG2yq9LNQe9gmGfQKYucnlmKHcpdIYB8I4d8=; b=Dp0Q7gw1ACeCRBycUUKp4wTzhNMfBFZbdILpCRgnBEsFqty70YYQ6udXb8gQkiQkrP wE/H5WpyKg8KIvNG/NfkshPN5eihc4T7yYyppWQTcXd18/s8EMNq9AJ/ID6Fm+BHs7oM T0bkvAwSCcOI9Icg/pj9p7Cle1GQqbt/vx5IJ5bsGk9u03FGjBf83ddcDHaHlDEkRQIY taH2X9EpvrcA+dA7jKEWC0l6iZ0wYmLi9uG+MdXyWETCTZUkKBoKbLA2txYb1vmgXjrn 0idSlYSI8X0jcRQm68OnhmPiC806JXl/R0i39rN7BHJbdTz7tWBtxulufd2Z1bMOU4Vt C0ig==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/TW7QwjOG2yq9LNQe9gmGfQKYucnlmKHcpdIYB8I4d8=; b=eeSoba+PJECSwhZ9t+wflAj71muxEcrFQxQci/yp4vVpjXbU1BDXERpMvysSg6NOY2 hLOlKuJpiBXKp8NfgXtUh/1j686b7+ICl9xshrkdc5GgH5XMmjd3R0/HGlqDid747F65 dhDyuqxCC+k3nAlwTE4OY6VOThcAeqTeCf+xVZJnfQ8Ga//0P55fCrlOGoQi6XWwojjr 5IE0tHyHD/qlSQJOypcU8N1+mI9f+LuVNXt9uWj3ys9UY0r7puyElIBRGE5R8iWVOrDA mu32qSw1QprgdxwxOq5i+ZCfAB+IChFM3NYBjxmEuNOhg7f209ELnal4dG/ooQlaUevP ZNbA==
X-Gm-Message-State AIVw110Xjdxh0CvW7OFuJPtsZTbhlo1hhDK1TVgV+q6O3zFSSwBdH9XI RhJFIDXBKcep4g==
X-Received by 10.84.194.131 with SMTP id h3mr9554417pld.82.1502005308383; Sun, 06 Aug 2017 00:41:48 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 6 Aug 2017 13:11:21 +0530
X-Original-Message-ID <1502005287-17705-3-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-References <1502005287-17705-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1704770

Show key headers only | View raw


usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 298a6ba..2578a76 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -408,7 +408,7 @@ static const signed short xpad_abs_triggers[] = {
 #define XPAD_XBOXONE_VENDOR(vend) \
 	{ XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) }
 
-static struct usb_device_id xpad_table[] = {
+static const struct usb_device_id xpad_table[] = {
 	{ USB_INTERFACE_INFO('X', 'B', 0) },	/* X-Box USB-IF not approved class */
 	XPAD_XBOX360_VENDOR(0x044f),		/* Thrustmaster X-Box 360 controllers */
 	XPAD_XBOX360_VENDOR(0x045e),		/* Microsoft X-Box 360 controllers */
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 2/8] Input: xpad: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:50 +0200

csiph-web