Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704707

Re: [PATCH] intel-vbtn: match power button on press rather than release

Show all headers | View raw

On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
> On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > > This fixes a problem where the system gets stuck in a loop
> > > unable to wakeup via power button in s2idle.
> > > 
> > > The problem happens because:
> > >  - press power button:
> > >    - system emits 0xc0 (power press), event ignored
> > >    - system emits 0xc1 (power release), event processed,
> > >      emited as KEY_POWER
> > >    - set wakeup_mode to true
> > >    - system goes to s2idle
> > >  - press power button
> > >    - system emits 0xc0 (power press), wakeup_mode is true,
> > >      system wakes
> > >    - system emits 0xc1 (power release), event processed,
> > >      emited as KEY_POWER
> > >    - system goes to s2idle again
> > > 
> > > To avoid this situation, process the presses (which matches what
> > > intel-hid does too).
> > > 
> > > Verified on an Dell XPS 9365
> > > 
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > 
> > This looks good to me - responding to the release is non-intuitive IMHO
> > anyway.  I'd like to see agreement from AceLan, but this should go into
> > the 4.13 rc cycle (at rc3 currently).
> 
> Yes, it should, and I'm not sure if the original author's opinion matters here.
> 
> The patch makes sense to everyone involved and fixes an annoying issue, so
> I don't see any real arguments against applying it.
> 
> Please feel free to add my ACK to it if that helps.

I always try to give those in MAINTAINERS a chance to respond, but I will queue
this up to fixes now.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] intel-vbtn: match power button on press rather than release Mario Limonciello <mario.limonciello@dell.com> - 2017-08-04 19:10 +0200
  Re: [PATCH] intel-vbtn: match power button on press rather than  release Darren Hart <dvhart@infradead.org> - 2017-08-04 19:40 +0200
    Re: [PATCH] intel-vbtn: match power button on press rather than release "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-05 01:40 +0200
      Re: [PATCH] intel-vbtn: match power button on press rather than  release Darren Hart <dvhart@infradead.org> - 2017-08-05 23:00 +0200
        Re: [PATCH] intel-vbtn: match power button on press rather than release "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-06 00:30 +0200
          Re: [PATCH] intel-vbtn: match power button on press rather than  release Darren Hart <dvhart@infradead.org> - 2017-08-07 01:30 +0200
            Re: [PATCH] intel-vbtn: match power button on press rather than release "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-07 02:40 +0200
              Re: [PATCH] intel-vbtn: match power button on press rather than release AceLan Kao <acelan.kao@canonical.com> - 2017-08-07 03:00 +0200
                Re: [PATCH] intel-vbtn: match power button on press rather than  release Darren Hart <dvhart@infradead.org> - 2017-08-07 06:00 +0200

csiph-web