Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705905

Re: [PATCH v2 06/23] clk: rockchip: support more clks for rv1108

From Heiko Stuebner <heiko@sntech.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 06/23] clk: rockchip: support more clks for rv1108
Date 2017-08-08 01:00 +0200
Message-ID <ubZaa-6Ws-3@gated-at.bofh.it> (permalink)
References <u9Xct-7q1-13@gated-at.bofh.it> <u9Xma-7tc-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Andy,

Am Mittwoch, 2. August 2017, 16:33:57 CEST schrieb Andy Yan:
> From: Elaine Zhang <zhangqing@rock-chips.com>
> 
> Added the description of the missing clock,
> make the clock tree more complete.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

[...]

>  	FACTOR(0, "xin12m", "xin24m", 0, 1, 2),
>  
> -	COMPOSITE(0, "i2s0_src", mux_pll_src_2plls_p, 0,
> +	/* PD_BUS */
> +	GATE(0, "aclk_bus_src_gpll", "gpll", CLK_IGNORE_UNUSED,
> +			RV1108_CLKGATE_CON(1), 0, GFLAGS),
> +	GATE(0, "aclk_bus_src_apll", "apll", CLK_IGNORE_UNUSED,
> +			RV1108_CLKGATE_CON(1), 1, GFLAGS),
> +	GATE(0, "aclk_bus_src_dpll", "dpll", CLK_IGNORE_UNUSED,
> +			RV1108_CLKGATE_CON(1), 2, GFLAGS),
> +	COMPOSITE_NOGATE(ACLK_PRE, "aclk_bus_pre", mux_aclk_bus_src_p, 0,
> +			RV1108_CLKSEL_CON(2), 8, 2, MFLAGS, 0, 5, DFLAGS),
> +	COMPOSITE_NOMUX(HCLK_BUS, "hclk_bus_pre", "aclk_bus_pre", 0,
> +			RV1108_CLKSEL_CON(3), 0, 5, DFLAGS,
> +			RV1108_CLKGATE_CON(1), 4, GFLAGS),

you're adding a (new / second) hclk_bus_pre here, but only drop the
old in patch 7. Please structure patch-contents in a way that each patch
is self-contained and works on its own ... aka the clock tree should not
get worse if only patch 6 is applied (like in a random git bisect), but
here the state is bad between these 2 patches.

hclk_bus_pre also is only _one_ example and there are probably more of
those hiding in these clock patches. So please fix these issues.


Thanks
Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/23] Support more devices on rockchip rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:30 +0200
  [PATCH v2 01/23] clk: rockchip: add more clk ids for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:30 +0200
    Re: [PATCH v2 01/23] clk: rockchip: add more clk ids for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-08 17:40 +0200
  [PATCH v2 05/23] clk: rockchip: fix up the pll clks error for rv1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
    Re: [PATCH v2 05/23] clk: rockchip: fix up the pll clks error for rv1108 SoC Heiko Stuebner <heiko@sntech.de> - 2017-08-08 01:00 +0200
  [PATCH v2 06/23] clk: rockchip: support more clks for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
    Re: [PATCH v2 06/23] clk: rockchip: support more clks for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-08 01:00 +0200
  [PATCH v2 08/23] clk: rockchip: rename some of clks for rv1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
  [PATCH v2 04/23] clk: rockchip: support more rates for cpuclk Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
    Re: [PATCH v2 04/23] clk: rockchip: support more rates for cpuclk Heiko Stuebner <heiko@sntech.de> - 2017-08-08 01:00 +0200
  [PATCH v2 09/23] clk: rockchip: add some critical clocks for rv1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
  [PATCH v2 03/23] clk: rockchip: fix up the indentation stuff for RV1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
    Re: [PATCH v2 03/23] clk: rockchip: fix up the indentation stuff for RV1108 SoC Heiko Stuebner <heiko@sntech.de> - 2017-08-08 17:40 +0200
  [PATCH v2 02/23] clk: rockchip: rename the clk id for HCLK_I2S1_2CH Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
    Re: [PATCH v2 02/23] clk: rockchip: rename the clk id for HCLK_I2S1_2CH Heiko Stuebner <heiko@sntech.de> - 2017-08-08 17:40 +0200
  [PATCH v2 07/23] clk: rockchip: fix up some clks describe error for rv1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:40 +0200
  [PATCH v2 12/23] i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
  [PATCH v2 10/23] pinctrl: rockchip: add schmitt input mode support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
    Re: [PATCH v2 10/23] pinctrl: rockchip: add schmitt input mode  support for rv1108 Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 11:00 +0200
  [PATCH v2 14/23] spi: rockchip: add compatible string for rv1108 spi Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
    Re: [PATCH v2 14/23] spi: rockchip: add compatible string for rv1108  spi Rob Herring <robh@kernel.org> - 2017-08-10 18:20 +0200
  [PATCH v2 16/23] dt-bindings: pwm: add description for rv1108 pwm Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
    Re: [PATCH v2 16/23] dt-bindings: pwm: add description for rv1108 pwm Rob Herring <robh@kernel.org> - 2017-08-10 18:20 +0200
  [PATCH v2 18/23] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
  [PATCH v2 11/23] dt-bindings: i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
    Re: [PATCH v2 11/23] dt-bindings: i2c: rk3x: add support for rv1108 Rob Herring <robh@kernel.org> - 2017-08-10 18:20 +0200
  [PATCH v2 17/23] ARM: dts: rockchip: add pwm dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
  [PATCH v2 15/23] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
  [PATCH v2 13/23] ARM: dts: rockchip: add i2c dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 10:50 +0200
  [PATCH v2 21/23] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 11:00 +0200
  [PATCH v2 19/23] dt-bindings: adc: add description for rv1108 saradc Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 11:00 +0200
    Re: [PATCH v2 19/23] dt-bindings: adc: add description for rv1108  saradc Rob Herring <robh@kernel.org> - 2017-08-10 18:20 +0200
  [PATCH v2 20/23] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 11:00 +0200
  [PATCH v2 23/23] ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 11:10 +0200
  [PATCH v2 22/23] ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 11:10 +0200

csiph-web