Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705859

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

Show all headers | View raw

Hi Robin,
Thank you for the review.

On 8/7/2017 7:17 AM, Robin Murphy wrote:
> Hi Neil,
> 
> On 04/08/17 20:59, Neil Leeder wrote:
[...]
>> +	res[1].start = pmcg->base_address + SZ_64K;
> 
> Ugh, I see there's a nasty spec hole here - IORT only defines one base
> address, but SMMUv3 says *both* pages have imp-def base addresses. I
> guess this assumption of them being in consecutive 64K regions holds for
> your platform, but as things stand it doesn't appear possible to rely on
> it generally :(
> 
> I'll follow up internally to see if we need to get IORT and/or SBSA
> updated or clarified.
> 
Thanks. I'll wait for the outcome before submitting a new patch.

[...]
>> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
>> index 707dda74..2169b6f 100644
>> --- a/include/acpi/actbl2.h
>> +++ b/include/acpi/actbl2.h
> 
> Hopefully these changes are merely here for reference, but just in case
> it needs to be said, they should go as a separate patch via ACPICA
> (presumably there's also some corresponding iASL stuff to compile PMCG
> nodes in the first place).
> 
Yes, I'll submit this to ACPICA once the IORT addresses get figured out.

Neil
-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] arm64 SMMUv3 PMU driver with IORT support Neil Leeder <nleeder@codeaurora.org> - 2017-08-04 22:00 +0200
  [PATCH 1/2] acpi: arm64: add iort support for PMCG Neil Leeder <nleeder@codeaurora.org> - 2017-08-04 22:00 +0200
    Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG Robin Murphy <robin.murphy@arm.com> - 2017-08-07 13:20 +0200
      Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG "Leeder, Neil" <nleeder@codeaurora.org> - 2017-08-07 23:00 +0200
    Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-08-07 18:50 +0200
      Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG "Leeder, Neil" <nleeder@codeaurora.org> - 2017-08-07 23:10 +0200
  [PATCH 2/2] perf: add arm64 smmuv3 pmu driver Neil Leeder <nleeder@codeaurora.org> - 2017-08-04 22:10 +0200
    Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver Robin Murphy <robin.murphy@arm.com> - 2017-08-07 16:40 +0200
      Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver "Leeder, Neil" <nleeder@codeaurora.org> - 2017-08-07 23:20 +0200
  Re: [PATCH 0/2] arm64 SMMUv3 PMU driver with IORT support Hanjun Guo <hanjun.guo@linaro.org> - 2017-08-09 10:00 +0200
    Re: [PATCH 0/2] arm64 SMMUv3 PMU driver with IORT support "Leeder, Neil" <nleeder@codeaurora.org> - 2017-08-09 17:50 +0200
      Re: [PATCH 0/2] arm64 SMMUv3 PMU driver with IORT support Hanjun Guo <hanjun.guo@linaro.org> - 2017-08-10 03:30 +0200
        Re: [PATCH 0/2] arm64 SMMUv3 PMU driver with IORT support "Leeder, Neil" <nleeder@codeaurora.org> - 2017-08-11 05:30 +0200

csiph-web