Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705628

Re: [PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym

Show all headers | View raw

Em Sun, Aug 06, 2017 at 11:24:34PM +0200, Milian Wolff escreveu:
> The input string is not modified and thus can be passed
> in as a pointer to const data.

Applied.

- Arnaldo
 
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Yao Jin <yao.jin@linux.intel.com>
> Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
> ---
>  tools/perf/util/symbol-elf.c     | 2 +-
>  tools/perf/util/symbol-minimal.c | 2 +-
>  tools/perf/util/symbol.h         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> index 502505cf236a..7cf18f14e152 100644
> --- a/tools/perf/util/symbol-elf.c
> +++ b/tools/perf/util/symbol-elf.c
> @@ -391,7 +391,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss, struct map *
>  	return 0;
>  }
>  
> -char *dso__demangle_sym(struct dso *dso, int kmodule, char *elf_name)
> +char *dso__demangle_sym(struct dso *dso, int kmodule, const char *elf_name)
>  {
>  	return demangle_sym(dso, kmodule, elf_name);
>  }
> diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c
> index 40bf5d4c0bfd..1a5aa35b0100 100644
> --- a/tools/perf/util/symbol-minimal.c
> +++ b/tools/perf/util/symbol-minimal.c
> @@ -377,7 +377,7 @@ void symbol__elf_init(void)
>  
>  char *dso__demangle_sym(struct dso *dso __maybe_unused,
>  			int kmodule __maybe_unused,
> -			char *elf_name __maybe_unused)
> +			const char *elf_name __maybe_unused)
>  {
>  	return NULL;
>  }
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index 41ebba9a2eb2..f0b08810d7fa 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -306,7 +306,7 @@ int dso__load_sym(struct dso *dso, struct map *map, struct symsrc *syms_ss,
>  int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss,
>  				struct map *map);
>  
> -char *dso__demangle_sym(struct dso *dso, int kmodule, char *elf_name);
> +char *dso__demangle_sym(struct dso *dso, int kmodule, const char *elf_name);
>  
>  void __symbols__insert(struct rb_root *symbols, struct symbol *sym, bool kernel);
>  void symbols__insert(struct rb_root *symbols, struct symbol *sym);
> -- 
> 2.13.3

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym Milian Wolff <milian.wolff@kdab.com> - 2017-08-06 23:30 +0200
  Re: [PATCH v2 02/14] perf util: take elf_name as const string in  dso__demangle_sym Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-07 17:20 +0200

csiph-web