Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver
Date	2017-08-07 11:30 +0200
Message-ID	<ubMwi-6nu-25@gated-at.bofh.it> (permalink)
References	<u0lSN-2dT-1@gated-at.bofh.it> <u0lSO-2dT-29@gated-at.bofh.it> <u9za9-8fB-11@gated-at.bofh.it> <u9BF0-1GX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 1, 2017 at 11:24 AM, Johan Hovold <johan@kernel.org> wrote:
> On Tue, Aug 01, 2017 at 08:49:02AM +0200, Linus Walleij wrote:
>> On Thu, Jul 6, 2017 at 10:49 PM, Anatolij Gustschin <agust@denx.de> wrote:
>>
>> > Add driver for CBUS pins on FT232H. The driver supports setting
>> > GPIO direction and getting/setting CBUS 0-3 pin value. The CBUS
>> > pins have to be enabled by configuring I/O mode in the FTDI EEPROM.
>> >
>> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
>
>> Apart from these small things it looks like a solid and nice driver,
>> do you plan to merge this into MFD or should I merge it? Since it depends
>> on the Kconfig symbol I guess I can merge it orthogonally if I am sure
>> Lee will pick the MFD part.
>
> There are some fundamental problems with this series which prevents it
> from being merged. Please take a look at the discussion following patch
> 1/3.

Allright it is on hold pending the MFD discussion.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2017-08-01 08:50 +0200
  Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Johan Hovold <johan@kernel.org> - 2017-08-01 11:30 +0200
    Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 11:30 +0200

csiph-web