Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures.
Date	Mon, 07 Aug 2017 11:30:02 +0200
Message-ID	<ubMwh-6nu-3@gated-at.bofh.it> (permalink)
References	<ubJI6-4Cv-5@gated-at.bofh.it>
Organization	Suse Linux
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.20.5
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
X-Original-Cc	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
X-Original-Date	Mon, 07 Aug 2017 11:25:50 +0200
X-Original-Message-ID	<1502097950.4007.82.camel@suse.de>
X-Original-References	<b4f5a71ff727f2bbd16aee1494ecf07e208830d2.1502086709.git.arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1705286

Show key headers only | View raw

Hi Arvind,

On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.

Confused by the subject. What is "wusbhc:"?

Also please avoid trailing dot in mail subjects.

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/hwmon/adt7475.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 1baa213..9ef8499 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR,
>  	NULL
>  };
>  
> -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
> -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
> -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
> -static struct attribute_group in0_attr_group = { .attrs = in0_attrs };
> -static struct attribute_group in3_attr_group = { .attrs = in3_attrs };
> -static struct attribute_group in4_attr_group = { .attrs = in4_attrs };
> -static struct attribute_group in5_attr_group = { .attrs = in5_attrs };
> -static struct attribute_group vid_attr_group = { .attrs = vid_attrs };
> +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
> +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
> +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
> +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs };
> +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs };
> +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs };
> +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs };
> +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>  
>  static int adt7475_detect(struct i2c_client *client,
>  			  struct i2c_board_info *info)

Looks good to me.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-07 08:30 +0200
  Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group  structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-07 11:30 +0200
  Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group  structures. Jean Delvare <jdelvare@suse.de> - 2017-08-07 11:30 +0200

csiph-web