Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705188

RE: [v5] wlcore: add missing nvs file name info for wilink8

Show all headers | View raw

Hi Tony,
> 
> * Reizer, Eyal <eyalr@ti.com> [170807 00:32]:
> > The following commits:
> > c815fde wlcore: spi: Populate config firmware data
> > d776fc8 wlcore: sdio: Populate config firmware data
> >
> > Populated the nvs entry for wilink6 and wilink7 only while it is
> > still needed for wilink8 as well.
> > This broke user space backward compatibility when upgrading from older
> > kernels, as the alternate mac address would not be read from the nvs that
> is
> > present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> > causing mac address change of the wlan interface.
> >
> > This patch fix this and update the structure field with the same default
> > nvs file name that has been used before.
> >
> > In addition, some distros hold a default wl1271-nvs.bin in the file
> > system with a bogus mac address (deadbeef...) that for a wl18xx device
> > also overrides the mac address that is stored inside the device.
> > Warn users about this bogus mac address and use a random mac instead
> 
> Hmm looks pretty good to me except for one more thing I just noticed.
> 
> Why don't you just use the hardware mac address instead of a random
> mac address on wl18xx device when you see a bogus nvs file?
> 

I agree that this would have been better but the problem is that hardware 
mac address is available for wilink8 onlyWilink6/7 don't have one stored.
The wlcore code responsible for handling mac address is common code 
and there is method for detecting between them in this module.

Best Regards,
Eyal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [v5] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-07 09:40 +0200
  RE: [v5] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-07 09:50 +0200
    Re: [v5] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-08 06:30 +0200
      RE: [v5] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-08 10:10 +0200
      RE: [v5] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-09 09:30 +0200
        Re: [v5] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-09 19:00 +0200

csiph-web