Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs()
Date	2017-08-07 05:40 +0200
Message-ID	<ubH3A-2S3-5@gated-at.bofh.it> (permalink)
References	<uaKwx-7py-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04-08-17, 14:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The if () in cpufreq_can_do_remote_dvfs() is superfluous, so drop
> it and simply return the value of the expression under it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> On top of the current linux-next.
> 
> ---
>  include/linux/cpufreq.h |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/include/linux/cpufreq.h
> ===================================================================
> --- linux-pm.orig/include/linux/cpufreq.h
> +++ linux-pm/include/linux/cpufreq.h
> @@ -578,11 +578,8 @@ static inline bool cpufreq_can_do_remote
>  	 * - dvfs_possible_from_any_cpu flag is set
>  	 * - the local and remote CPUs share cpufreq policy
>  	 */
> -	if (policy->dvfs_possible_from_any_cpu ||
> -	    cpumask_test_cpu(smp_processor_id(), policy->cpus))
> -		return true;
> -
> -	return false;
> +	return policy->dvfs_possible_from_any_cpu ||
> +		cpumask_test_cpu(smp_processor_id(), policy->cpus);
>  }
>  
>  /*********************************************************************

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-04 15:10 +0200
  Re: [PATCH] cpufreq: Simplify cpufreq_can_do_remote_dvfs() Viresh Kumar <viresh.kumar@linaro.org> - 2017-08-07 05:40 +0200

csiph-web