Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.

From	Masanori Goto <gotom@debian.or.jp>
Newsgroups	linux.kernel
Subject	Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.
Date	2017-08-07 03:40 +0200
Message-ID	<ubFbs-1A5-11@gated-at.bofh.it> (permalink)
References	<u8S5c-6pl-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-07-30 17:43 GMT+09:00 Arvind Yadav <arvind.yadav.cs@gmail.com>:
>
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thank you!  (resending it twice due to an error)

Acked-by: Masanori Goto <gotom@debian.or.jp>


> ---
>  drivers/scsi/nsp32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 53c8477..1430b3c 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2";
>  /****************************************************************************
>   * Supported hardware
>   */
> -static struct pci_device_id nsp32_pci_table[] = {
> +static const struct pci_device_id nsp32_pci_table[] = {
>         {
>                 .vendor      = PCI_VENDOR_ID_IODATA,
>                 .device      = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
> --
> 2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id. Masanori Goto <gotom@debian.or.jp> - 2017-08-07 03:40 +0200

csiph-web