Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705052

Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API

Show all headers | View raw

Dear Felipe,

Could you please review this patch?
I hope to remove the deprecated extcon API.

Regards,
Chanwoo Choi

On 2017년 08월 03일 17:20, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
> 
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19e07ae..0ce7b3ba60ff 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev)
>  			goto exit_phy;
>  		}
>  
> -		ret = extcon_get_cable_state_(udc->edev, EXTCON_USB);
> +		ret = extcon_get_state(udc->edev, EXTCON_USB);
>  		if (ret < 0) {
>  			dev_err(dev, "Can't get cable state\n");
>  			goto exit_extcon;
> @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev)
>  	udc = dev_get_drvdata(dev);
>  	stop_udc(udc);
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "device -> idle\n");
>  		stop_udc(udc);
>  	}
> @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "idle -> device\n");
>  		start_udc(udc);
>  	}
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] usb: Replace the deprecated extcon API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-03 10:30 +0200
  [PATCH v2 2/5] phy: rockchip-inno-usb2: Replace the extcon API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-03 10:30 +0200
  [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-03 10:30 +0200
    Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon  API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-07 04:10 +0200
      Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon  API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-10 02:10 +0200
  [PATCH v2 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated  extcon API Chanwoo Choi <cw00.choi@samsung.com> - 2017-08-03 10:30 +0200

csiph-web