Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1705014
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/3] power: supply: charger-manager: Fix a NULL pointer dereference in 'charger_manager_probe()' |
| Date | Mon, 07 Aug 2017 00:40:01 +0200 |
| Message-ID | <ubCnf-893-7@gated-at.bofh.it> (permalink) |
| References | <ubCnf-893-5@gated-at.bofh.it> |
| X-Original-To | sre@kernel.org |
| X-Me-Helo | localhost.localdomain |
| X-Me-Auth | Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= |
| X-Me-Date | Mon, 07 Aug 2017 00:38:34 +0200 |
| X-Me-IP | 90.21.163.120 |
| X-Mailer | git-send-email 2.11.0 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 23 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| X-Original-Date | Mon, 7 Aug 2017 00:37:55 +0200 |
| X-Original-Message-ID | <09a9f8a61f784779d6127b83f9540ae1db4c25be.1502058761.git.christophe.jaillet@wanadoo.fr> |
| X-Original-References | <cover.1502058761.git.christophe.jaillet@wanadoo.fr> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1705014 |
Show key headers only | View raw
'devm_kzalloc()' can return NULL. Return -ENOMEM in this case in order to
avoid a NULL pointer dereference later on.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/power/supply/charger-manager.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
index adc3761831e1..52a49857e20f 100644
--- a/drivers/power/supply/charger-manager.c
+++ b/drivers/power/supply/charger-manager.c
@@ -1645,6 +1645,8 @@ static int charger_manager_probe(struct platform_device *pdev)
/* Initialize alarm timer */
if (alarmtimer_get_rtcdev()) {
cm_timer = devm_kzalloc(cm->dev, sizeof(*cm_timer), GFP_KERNEL);
+ if (!cm_timer)
+ return -ENOMEM;
alarm_init(cm_timer, ALARM_BOOTTIME, cm_timer_func);
}
--
2.11.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 1/3] power: supply: charger-manager: Fix a NULL pointer dereference in 'charger_manager_probe()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-07 00:40 +0200
csiph-web