Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704972

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

From Mikko Rapeli <mikko.rapeli@iki.fi>
Newsgroups linux.kernel
Subject Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h
Date 2017-08-06 23:10 +0200
Message-ID <ubAYa-7l9-15@gated-at.bofh.it> (permalink)
References <ubxdT-50T-3@gated-at.bofh.it> <ubxdU-50T-21@gated-at.bofh.it> <ubytj-5JT-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote:
> On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote:
> > Fixes userspace compilation errors like:
> > 
> > scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list 
> > before ‘uint64_t’
> 
> Rather than patching the kernel, why not #include <stdint.h> in your
> userspace programme?

The userspace program is actually a test which checks that uapi headers
compile alone because several headers are not compiling at all and/or
require special tricks. The test is available here:

http://marc.info/?l=linux-kernel&m=150203944104544&w=2

I have tried that approach before but then:

https://lkml.org/lkml/2015/6/1/160

For some subsystems like fuse the above message was not enough and they
are including stdint.h in userspace. What shall we do with this old
scsi header file?

-Mikko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2017-08-06 19:10 +0200
  Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32  and __u64 from linux/types.h James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-08-06 20:30 +0200
    Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32  and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2017-08-06 23:10 +0200
      Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32  and __u64 from linux/types.h James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-08-07 00:20 +0200
        Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32  and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2017-08-07 08:10 +0200

csiph-web