Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703444
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Bjorn Helgaas <helgaas@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 052/102] PCI: imx6: explicitly request exclusive reset control |
| Date | Thu, 03 Aug 2017 23:50:01 +0200 |
| Message-ID | <uawad-5UG-5@gated-at.bofh.it> (permalink) |
| References | <u4Z5f-1XQ-3@gated-at.bofh.it> <u4ZoD-27S-61@gated-at.bofh.it> |
| Dmarc-Filter | OpenDMARC Filter v1.3.2 mail.kernel.org 4169322B5D |
| Authentication-Results | mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org |
| Authentication-Results | mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 50 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Richard Zhu <hongxing.zhu@nxp.com>, Lucas Stach <l.stach@pengutronix.de>, Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org |
| X-Original-Date | Thu, 3 Aug 2017 16:41:50 -0500 |
| X-Original-Message-ID | <20170803214149.GC20308@bhelgaas-glaptop.roam.corp.google.com> |
| X-Original-References | <20170719152646.25903-1-p.zabel@pengutronix.de> <20170719152646.25903-53-p.zabel@pengutronix.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1703444 |
Show key headers only | View raw
On Wed, Jul 19, 2017 at 05:25:56PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to pci/host-imx6 for v4.14, thanks!
Richard, Lucas, holler if you see any issues.
> ---
> drivers/pci/dwc/pci-imx6.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
> index bf5c3616e3448..5a2ece394ad39 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -778,14 +778,15 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> }
> break;
> case IMX7D:
> - imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> - "pciephy");
> + imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev,
> + "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> - imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
> + imx6_pcie->apps_reset = devm_reset_control_get_exclusive(dev,
> + "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> dev_err(dev, "Failed to get PCIE APPS reset control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> --
> 2.11.0
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 052/102] PCI: imx6: explicitly request exclusive reset control Bjorn Helgaas <helgaas@kernel.org> - 2017-08-03 23:50 +0200
csiph-web