Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703449

Re: [PATCH] Drivers: usb: serial: Replace unsigned to unsigned int and fix line over 80 characters

Show all headers | View raw

On Fri, Aug 04, 2017 at 02:21:13AM +0530, Himanshu Jha wrote:
> This patch fixes the following checkpatch.pl warnings:
> 
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
>  drivers/usb/serial/ch341.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

Note, I'm not Johan, but I only take patches that do one thing at a
time, and no, "fixing all coding style issues" is not one thing :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Drivers: usb: serial: Replace unsigned to unsigned int and fix line over 80 characters Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-03 23:00 +0200
  Re: [PATCH] Drivers: usb: serial: Replace unsigned to unsigned int  and fix line over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-08-03 23:50 +0200

csiph-web