Re: [PATCH] ACPI / dock: constify attribute_group structures.

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI / dock: constify attribute_group structures.
Date	2017-08-04 00:20 +0200
Message-ID	<uawDf-6my-1@gated-at.bofh.it> (permalink)
References	<uaocG-rc-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 3, 2017 at 3:18 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Somebody else sent an analogous patch earlier, so I'm going to take that one.

> ---
>  drivers/acpi/dock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index 0c00208..2305e1a 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -585,7 +585,7 @@ static ssize_t show_dock_type(struct device *dev,
>         NULL
>  };
>
> -static struct attribute_group dock_attribute_group = {
> +static const struct attribute_group dock_attribute_group = {
>         .attrs = dock_attributes
>  };
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI / dock: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 15:20 +0200
  Re: [PATCH] ACPI / dock: constify attribute_group structures. "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-04 00:20 +0200

csiph-web