Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers

From	Jyri Sarha <jsarha@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers
Date	2017-08-03 19:40 +0200
Message-ID	<uasgj-3eZ-29@gated-at.bofh.it> (permalink)
References	<uan6V-8co-3@gated-at.bofh.it> <uan6W-8co-27@gated-at.bofh.it> <uaoPn-Jx-5@gated-at.bofh.it> <uaqxQ-1Y5-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 08/03/17 18:42, Daniel Vetter wrote:
> On Thu, Aug 3, 2017 at 3:56 PM, Jyri Sarha <jsarha@ti.com> wrote:
>>
>> On 08/03/17 14:58, Cihangir Akturk wrote:
>>> drm_*_reference() and drm_*_unreference() functions are just
>>> compatibility alias for drm_*_get() and drm_*_put() adn should not be
>>> used by new code. So convert all users of compatibility functions to use
>>> the new APIs.
>>>
>>> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
>> Acked-by: Jyri Sarha <jsarha@ti.com>
>>
>> This appears to be a part of a larger series. So I guess it will go in
>> via drm-misc. But if this is not the case just let me know and I'll add
>> this to my next pull request.
> Only if you join drm-misc and push it there yourself :-)
> 
> In general I prefer driver maintainers pick up their stuff for patch
> series which don't have depencies like this here, otherwise, why
> exactly do we have driver maintainers.
> 

I assumed that the series would deprecate drm_framebuffer_unreference()
and -reference() aliases (if we are cleaning things up, why wouldn't we
go all the way?). But if that is not the case, then by all means I'll
pick the patch for a 4.14 tilcdc pull request.

Cheers,
Jyri

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Cihangir Akturk <cakturk@gmail.com> - 2017-08-03 14:10 +0200
  Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Jyri Sarha <jsarha@ti.com> - 2017-08-03 16:00 +0200
    Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Daniel Vetter <daniel@ffwll.ch> - 2017-08-03 17:50 +0200
      Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Jyri Sarha <jsarha@ti.com> - 2017-08-03 19:40 +0200

csiph-web