Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703319
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats |
| Date | 2017-08-03 20:10 +0200 |
| Message-ID | <uasJj-3EH-1@gated-at.bofh.it> (permalink) |
| References | <uakVr-6xq-3@gated-at.bofh.it> <uakVr-6xq-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/03/2017 02:45 AM, Egil Hjelmeland wrote:
> In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic
> by using new lan9303_read_switch_reg() inside loop.
> Reduced scope of two variables.
>
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> ---
> drivers/net/dsa/lan9303-core.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> index 6f409755ba1a..5aaa46146c27 100644
> --- a/drivers/net/dsa/lan9303-core.c
> +++ b/drivers/net/dsa/lan9303-core.c
> @@ -435,6 +435,13 @@ static int lan9303_write_switch_port(
> chip, LAN9303_SWITCH_PORT_REG(port, regnum), val);
> }
>
> +static int lan9303_read_switch_port(
> + struct lan9303 *chip, int port, u16 regnum, u32 *val)
> +{
This indentation is really funny, why not just break it up that way:
static int lan9303_read_switch_port(struct lan9303 *chip, int port
u16 regnum, u32 *val)
{
}
This applies to patch 5 as well, other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> + return lan9303_read_switch_reg(
> + chip, LAN9303_SWITCH_PORT_REG(port, regnum), val);
> +}
> +
> static int lan9303_detect_phy_setup(struct lan9303 *chip)
> {
> int reg;
> @@ -709,19 +716,18 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
> uint64_t *data)
> {
> struct lan9303 *chip = ds->priv;
> - u32 reg;
> - unsigned int u, poff;
> - int ret;
> -
> - poff = port * 0x400;
> + unsigned int u;
>
> for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> - ret = lan9303_read_switch_reg(chip,
> - lan9303_mib[u].offset + poff,
> - ®);
> + u32 reg;
> + int ret;
> +
> + ret = lan9303_read_switch_port(
> + chip, port, lan9303_mib[u].offset, ®);
> +
> if (ret)
> - dev_warn(chip->dev, "Reading status reg %u failed\n",
> - lan9303_mib[u].offset + poff);
> + dev_warn(chip->dev, "Reading status port %d reg %u failed\n",
> + port, lan9303_mib[u].offset);
> data[u] = reg;
> }
> }
>
--
Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 net-next 0/5] Refactor lan9303_xxx_packet_processing Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
[PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Andrew Lunn <andrew@lunn.ch> - 2017-08-03 15:40 +0200
Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Florian Fainelli <f.fainelli@gmail.com> - 2017-08-03 20:10 +0200
Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 22:30 +0200
[PATCH v3 net-next 2/5] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
Re: [PATCH v3 net-next 2/5] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Andrew Lunn <andrew@lunn.ch> - 2017-08-03 15:30 +0200
Re: [PATCH v3 net-next 2/5] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Florian Fainelli <f.fainelli@gmail.com> - 2017-08-03 20:10 +0200
[PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
Re: [PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Andrew Lunn <andrew@lunn.ch> - 2017-08-03 15:30 +0200
Re: [PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Florian Fainelli <f.fainelli@gmail.com> - 2017-08-03 20:10 +0200
Re: [PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 22:20 +0200
[PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing() Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
Re: [PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing() Andrew Lunn <andrew@lunn.ch> - 2017-08-03 15:30 +0200
Re: [PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing() Florian Fainelli <f.fainelli@gmail.com> - 2017-08-03 20:10 +0200
[PATCH v3 net-next 1/5] net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param. Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-08-03 11:50 +0200
Re: [PATCH v3 net-next 1/5] net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param. Andrew Lunn <andrew@lunn.ch> - 2017-08-03 15:30 +0200
Re: [PATCH v3 net-next 1/5] net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param. Florian Fainelli <f.fainelli@gmail.com> - 2017-08-03 20:10 +0200
csiph-web