Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1703298

[PATCH 3/5] PCI: hotplug: bmphp_ebda: constify pci_device_id.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 3/5] PCI: hotplug: bmphp_ebda: constify pci_device_id.
Date 2017-08-03 19:20 +0200
Message-ID <uarWX-37e-45@gated-at.bofh.it> (permalink)
References <uarWW-37e-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/pci/hotplug/ibmphp_ebda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/ibmphp_ebda.c b/drivers/pci/hotplug/ibmphp_ebda.c
index 43e345a..a6a4dac 100644
--- a/drivers/pci/hotplug/ibmphp_ebda.c
+++ b/drivers/pci/hotplug/ibmphp_ebda.c
@@ -1153,7 +1153,7 @@ void ibmphp_free_ebda_pci_rsrc_queue(void)
 	}
 }
 
-static struct pci_device_id id_table[] = {
+static const struct pci_device_id id_table[] = {
 	{
 		.vendor		= PCI_VENDOR_ID_IBM,
 		.device		= HPC_DEVICE_ID,
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] constify hotplug pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 19:20 +0200
  [PATCH 1/5] PCI: hotplug: shpchp: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 19:20 +0200
  [PATCH 3/5] PCI: hotplug: bmphp_ebda: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 19:20 +0200
  Re: [PATCH 0/5] constify hotplug pci_device_id Bjorn Helgaas <helgaas@kernel.org> - 2017-08-04 01:00 +0200
    Re: [PATCH 0/5] constify hotplug pci_device_id Bjorn Helgaas <helgaas@kernel.org> - 2017-08-04 01:30 +0200

csiph-web