Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1703289

[PATCH 2/5] PCI: hotplug: ibmphp: constify pci_device_id.

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/5] PCI: hotplug: ibmphp: constify pci_device_id.
Date Thu, 03 Aug 2017 19:20:02 +0200
Message-ID <uarWW-37e-3@gated-at.bofh.it> (permalink)
References <uarWW-37e-5@gated-at.bofh.it>
X-Original-To bhelgaas@google.com, scott@spiteful.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EIGjrVkAr0OltNLX0uWn9EYGt6IbEvM6fVG4uweocYo=; b=lVNO2r6wvQtOhGh/X1B6r1Q7frsc+KbRsdUGyrwFbUyXv1C3TqefGgWTegnk87A01L AugnaaxjZTvqsiYLGRWdDGRFieRFww16sBU78YVmmJUo3ux2CEL8Vlyru2sFOxxDW9+7 SErGVl5FYa5eaCXPgEscDjXRXRs4y9nW6iEHSLcbDdLwzfA4Xlbrnhp5Ns422kZOrGG5 d9eAMuWQvapRBRFOZOKJARt1fF8L7C0S+irTFXakIrggF3Jz+S0ejR0d4b1k/ILaeb6A J4WMXhU4EmkR91ZQWlvgHIozTNrmK27q9i2+KW0e1Xamra+QcICMmcE1OaIEWGjUhOwm oG9g==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EIGjrVkAr0OltNLX0uWn9EYGt6IbEvM6fVG4uweocYo=; b=KDQ9MoiWNgxUbihK8PbOg/HT1miieQcnvq2ZWOKE1e4Patzpvbz2ZRueGgVguQogUW NuA35MbmONPxwDIl7OjaRTf4EyIXCaH2UGdVmLhplvQvXf6nfpFvz/tY5TbCwINaRASx nsYFWQEgTbWK9s8wos6ucDF6KrxhGNUx7wSQX6tw8Tx4MNpxa1HAr3nH9ijibPrhZ09y jOKZE3RWpYZHVVOERih7MNABbMWNfNL+JqkGY4t1j+oEv3lEJ2fBe/R/OjaoNET3INTB fJjkskmA0U23lqDvwzWTPWkWXdidmw5TTPDqiuy0OdyvBpZp0dCJ6+s2qpO3bqPp+6jv w0jA==
X-Gm-Message-State AIVw113jvX0ogoKVZPUFytjsY5Umo24lbHLWedmXTk5FQO15CRFT/Zam cD3bgPieDIXkaDpsI/4=
X-Received by 10.84.210.40 with SMTP id z37mr2580531plh.265.1501780206346; Thu, 03 Aug 2017 10:10:06 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
X-Original-Date Thu, 3 Aug 2017 22:39:13 +0530
X-Original-Message-ID <1501780156-24708-3-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-References <1501780156-24708-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1703289

Show key headers only | View raw


pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/pci/hotplug/ibmphp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index 5efd01d..73cf846 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -852,7 +852,7 @@ static int set_bus(struct slot *slot_cur)
 	u8 speed;
 	u8 cmd = 0x0;
 	int retval;
-	static struct pci_device_id ciobx[] = {
+	static const struct pci_device_id ciobx[] = {
 		{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, 0x0101) },
 		{ },
 	};
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 2/5] PCI: hotplug: ibmphp: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 19:20 +0200

csiph-web