Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys

From	João Paulo Rechi Vita <jprvita@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys
Date	2017-08-03 17:30 +0200
Message-ID	<uaqeu-1Q1-9@gated-at.bofh.it> (permalink)
References	<u6T5o-25X-21@gated-at.bofh.it> <u6T5o-25X-19@gated-at.bofh.it> <u9Y8x-83f-17@gated-at.bofh.it> <ua0N4-1m9-27@gated-at.bofh.it> <uakC7-6qh-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 3, 2017 at 2:24 AM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 2 Aug 2017, Benjamin Tissoires wrote:
>
>> Sorry for the delay. I was at GUADEC the whole past week and couldn't
>> get much kernel work done. I was thinking a little bit about this series
>> though. Patch 1 is fine, but patch 2 is a little bit more of an issue.
>> Ideally, I'd like to keep hid-multitouch from having too many vendor
>> specific code, but it looks like this is the easier way to handle things
>> here.
>>
>> I guess the proper way of solving this situation would be to merge the
>> generic windows 8 code from hid-multitouch into hid-input so that other
>> drivers can benefit from it, but this is going to be a lot of work and
>> -ETIME.
>
> Yes, I actually have this on the list of things I'd eventually like to
> look into one day ... but we shouldn't let this block any further
> development.
>
> I have applied the series now to for-4.14/multitouch (fixing up the
> 0xff310076 -> HID_VD_ASUS_CUSTOM_MEDIA_KEYS constant in the condition as a
> followup).
>

Thanks!

--
João Paulo Rechi Vita
http://about.me/jprvita

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys Jiri Kosina <jikos@kernel.org> - 2017-08-02 11:30 +0200
  Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-08-02 14:20 +0200
    Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys Jiri Kosina <jikos@kernel.org> - 2017-08-03 11:30 +0200
      Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys João Paulo Rechi Vita <jprvita@gmail.com> - 2017-08-03 17:30 +0200

csiph-web