Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703128
| From | Noralf Trønnes <noralf@tronnes.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. |
| Date | 2017-08-03 15:40 +0200 |
| Message-ID | <uaow4-Bh-51@gated-at.bofh.it> (permalink) |
| References | <ua8AV-6r3-7@gated-at.bofh.it> <ua8AW-6r3-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Den 02.08.2017 22.32, skrev Eric Anholt:
> The clocks are enabled/disabled at encoder enable/disable time, not at
> component load. Fixes a WARN_ON at boot if V3D fails to probe.
>
> Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
Acked-by: Noralf Trønnes <noralf@tronnes.org>
> drivers/gpu/drm/vc4/vc4_dsi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 629d372633e6..13481bb6322f 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>
> mipi_dsi_host_unregister(&dsi->dsi_host);
>
> - clk_disable_unprepare(dsi->pll_phy_clock);
> - clk_disable_unprepare(dsi->escape_clock);
> -
> if (dsi->port == 1)
> vc4->dsi1 = NULL;
> }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Eric Anholt <eric@anholt.net> - 2017-08-02 22:40 +0200 Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Noralf Trønnes <noralf@tronnes.org> - 2017-08-03 15:40 +0200 Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-04 12:10 +0200
csiph-web