Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1703117

[PATCH 2/3] firmware: efi: constify attribute_group structures.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] firmware: efi: constify attribute_group structures.
Date 2017-08-03 15:40 +0200
Message-ID <uaow2-Bh-11@gated-at.bofh.it> (permalink)
References <uaow2-Bh-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/firmware/efi/efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 045d6d3..6519be44 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -179,7 +179,7 @@ static umode_t efi_attr_is_visible(struct kobject *kobj,
 	return attr->mode;
 }
 
-static struct attribute_group efi_subsys_attr_group = {
+static const struct attribute_group efi_subsys_attr_group = {
 	.attrs = efi_subsys_attrs,
 	.is_visible = efi_attr_is_visible,
 };
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] constify firmware attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 15:40 +0200
  [PATCH 2/3] firmware: efi: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 15:40 +0200
  [PATCH 1/3] firmware: dcdbas: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 15:40 +0200
  [PATCH 3/3] firmware: efi: esrt: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 15:40 +0200

csiph-web