Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703154

Re: [PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers

Show all headers | View raw

Hi Cihangir,

On Thu, Aug 03, 2017 at 02:58:17PM +0300, Cihangir Akturk wrote:
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to use
> the new APIs.

Thank you for the patch!

> 
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

I will pull the patch and send it to Dave.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 600fa7b..cb71360 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -57,7 +57,7 @@ static void malidp_de_plane_destroy(struct drm_plane *plane)
>  	struct malidp_plane *mp = to_malidp_plane(plane);
>  
>  	if (mp->base.fb)
> -		drm_framebuffer_unreference(mp->base.fb);
> +		drm_framebuffer_put(mp->base.fb);
>  
>  	drm_plane_helper_disable(plane);
>  	drm_plane_cleanup(plane);
> -- 
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers Cihangir Akturk <cakturk@gmail.com> - 2017-08-03 14:10 +0200
  Re: [PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers Liviu Dudau <liviu.dudau@arm.com> - 2017-08-03 16:10 +0200

csiph-web